Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ Merge task (kind) data. #655

Merged
merged 4 commits into from
Jun 12, 2024
Merged

✨ Merge task (kind) data. #655

merged 4 commits into from
Jun 12, 2024

Conversation

jortel
Copy link
Contributor

@jortel jortel commented Jun 12, 2024

Merge Task (kind) data into Task model data. This is to support defining data properties in the task kind to be inherrited by models. Properties in Task (model) data have priority.
In the interest of keeping models simple, moves TaskGroup.Propagate() to the api. No need for it to be in the model. To support this, the Merge() method was also moved to BaseHandler as it is used by multiple handlers.

Example:

---
kind: Task
apiVersion: tackle.konveyor.io/v1alpha1
metadata:
  namespace: konveyor-tackle
  name: tech-discovery
spec:
  data:
    mode:
      discovery: true
    rules:
      labels:
        included:
          - techA
          - techB

Signed-off-by: Jeff Ortel <jortel@redhat.com>
Signed-off-by: Jeff Ortel <jortel@redhat.com>
@jortel jortel marked this pull request as ready for review June 12, 2024 15:19
Signed-off-by: Jeff Ortel <jortel@redhat.com>
Signed-off-by: Jeff Ortel <jortel@redhat.com>
Copy link
Collaborator

@mansam mansam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants