-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🐛 Detect image issues. #678
Conversation
Signed-off-by: Jeff Ortel <jortel@redhat.com>
89feb66
to
23bb909
Compare
task/manager.go
Outdated
if state.Waiting != nil { | ||
waiting := state.Waiting | ||
reason := strings.ToLower(waiting.Reason) | ||
if strings.Contains(reason, "invalid") || strings.Contains(reason, "backoff") { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would it be better to specifically match ImagePullBackOff
and InvalidImageName
, if those are the only cases we intend to catch?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perhaps but I cannot find a const in v1 or core packages and concerned about making the match too narrow should the strings change a little. Also, a little broader match may catch other similar issues.
I cannot find an Enum for all the possible values.
Signed-off-by: Jeff Ortel <jortel@redhat.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Signed-off-by: Jeff Ortel <jortel@redhat.com>
Signed-off-by: Jeff Ortel <jortel@redhat.com>
This reverts commit 83b8519.
Re-apply reverted #678 re-based on current main. --------- Signed-off-by: Jeff Ortel <jortel@redhat.com>
Detect malformed fqin and image pull backoff. When detected, the task is failed and reported with error and event.
Reported as:
Detects:
closes: #677