Skip to content

Commit

Permalink
🐛 Address style issues on assessment summary / questionnaire view pages
Browse files Browse the repository at this point in the history
  • Loading branch information
ibolton336 committed Feb 27, 2024
1 parent 2febd18 commit 1e88338
Show file tree
Hide file tree
Showing 6 changed files with 15 additions and 17 deletions.
1 change: 1 addition & 0 deletions client/public/locales/en/translation.json
Original file line number Diff line number Diff line change
Expand Up @@ -322,6 +322,7 @@
"email": "Email",
"error": "Error",
"errorReport": "Error report",
"explanation": "Explanation",
"exclude": "Exclude",
"exportToIssue": "Export to Issue Manager",
"facts": "Facts",
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -166,6 +166,7 @@ const QuestionnaireSummary: React.FC<QuestionnaireSummaryProps> = ({
isVertical
aria-label="Tabs for summaryData sections"
role="region"
className="tabs-vertical-container__tabs"
>
{[
<Tab
Expand Down
13 changes: 8 additions & 5 deletions client/src/app/components/questions-table/questions-table.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -178,11 +178,14 @@ const QuestionsTable: React.FC<{
className={spacing.pyLg}
>
<ExpandableRowContent>
{question.explanation}
<AnswerTable
hideAnswerKey={hideAnswerKey}
answers={question.answers}
/>
<div className={spacing.mlMd}>
<strong>{t("terms.explanation")}: &nbsp;</strong>
<span>{question.explanation}</span>
<AnswerTable
hideAnswerKey={hideAnswerKey}
answers={question.answers}
/>
</div>
</ExpandableRowContent>
</Td>
</Tr>
Expand Down
Original file line number Diff line number Diff line change
@@ -1,5 +1,10 @@
.tabs-vertical-container {
display: flex;
margin-top: 1.5em;
}

.tabs-vertical-container__tabs {
margin-top: 1.5em;
}

.tabs-vertical-container .pf-v5-c-tabs {
Expand Down

This file was deleted.

Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
import React from "react";
import { useParams } from "react-router-dom";
import "./assessment-summary-page.css";
import QuestionnaireSummary, {
SummaryType,
} from "@app/components/questionnaire-summary/questionnaire-summary";
Expand Down

0 comments on commit 1e88338

Please sign in to comment.