Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Missing application selection values in issues table filter #1754

Closed
ibolton336 opened this issue Mar 8, 2024 · 3 comments · Fixed by #1771
Closed

Missing application selection values in issues table filter #1754

ibolton336 opened this issue Mar 8, 2024 · 3 comments · Fixed by #1771
Assignees
@rszwajko
Labels
needs-kind Indicates an issue or PR lacks a `kind/foo` label and requires one. needs-priority Indicates an issue or PR lacks a `priority/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one.
Milestone
v0.3.1

Comments

@ibolton336
Copy link
Member

Screenshot 2024-03-08 at 11 11 57 AM
@konveyor-ci-bot konveyor-ci-bot bot added the needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. label Mar 8, 2024
@konveyor-ci-bot
Copy link

This issue is currently awaiting triage.
If contributors determine this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.
The triage/accepted label can be added by org members.

@konveyor-ci-bot konveyor-ci-bot bot added needs-kind Indicates an issue or PR lacks a `kind/foo` label and requires one. needs-priority Indicates an issue or PR lacks a `priority/foo` label and requires one. labels Mar 8, 2024
@rszwajko
Copy link
Collaborator

@ibolton336
It seems that we are using there a server side search filter - see

tackle2-ui/client/src/app/pages/issues/helpers.ts

Line 50 in c2ef03c

type: FilterType.search,

If I understand the issue correctly, we would like to use multiselect filtering (choosing apps from the list). However this assumes that we know the names already. Do we need to fetch available apps first?

@ibolton336
Copy link
Member Author

@ibolton336 It seems that we are using there a server side search filter - see

tackle2-ui/client/src/app/pages/issues/helpers.ts

Line 50 in c2ef03c

type: FilterType.search,

If I understand the issue correctly, we would like to use multiselect filtering (choosing apps from the list). However this assumes that we know the names already. Do we need to fetch available apps first?

Good point - I think we do have all of the application names cached locally so I was thinking we could just use those rather than an additional fetch here.

@rszwajko rszwajko mentioned this issue Mar 13, 2024
Merged
ibolton336 added a commit that referenced this issue Mar 14, 2024
@rszwajko @ibolton336
🌱 Use multi select filter for application names (#1771)
36ca738 
Resolves: #1754

Signed-off-by: Radoslaw Szwajkowski <rszwajko@redhat.com>
Co-authored-by: Ian Bolton <ibolton@redhat.com>
@sjd78 sjd78 added this to the v0.3.1 milestone Mar 14, 2024
ibolton336 added a commit to ibolton336/tackle2-ui that referenced this issue Apr 8, 2024
@rszwajko @ibolton336
🌱 Use multi select filter for application names (konveyor#1771)
71176c5 
Resolves: konveyor#1754

Signed-off-by: Radoslaw Szwajkowski <rszwajko@redhat.com>
Co-authored-by: Ian Bolton <ibolton@redhat.com>
@ibolton336 ibolton336 mentioned this issue Apr 8, 2024
Merged
ibolton336 added a commit that referenced this issue Apr 8, 2024
@ibolton336 @rszwajko
🌱 MTA-2560: Use multi select filter for application names (#1771) (#1828
3596d7d 
)

Resolves: #1754
Resolves: https://issues.redhat.com/browse/MTA-2560

Signed-off-by: Radoslaw Szwajkowski <rszwajko@redhat.com>
Co-authored-by: Radoslaw Szwajkowski <rszwajko@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rszwajko rszwajko

Labels
needs-kind Indicates an issue or PR lacks a `kind/foo` label and requires one. needs-priority Indicates an issue or PR lacks a `priority/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one.
Projects
Planning
Status: ✅ Done
Milestone
v0.3.1
Development

Successfully merging a pull request may close this issue.

🌱 Use multi select filter for application names rszwajko/tackle2-ui
3 participants
@sjd78 @ibolton336 @rszwajko