Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Show disabled tooltip for export when no apps available for export #1691

Merged
merged 3 commits into from
Feb 22, 2024

Conversation

ibolton336
Copy link
Member

@ibolton336 ibolton336 commented Feb 16, 2024

Resolves https://issues.redhat.com/browse/MTA-1845
After discussions with UXD ( @JustinXHale ), determined that this export functionality can safely be disabled when no apps are available to export. Apps that have already been exported already are assigned to a ticket and Jira and cannot be re-exported until they are unlinked.

Screenshot 2024-02-16 at 3 49 30 PM

>
<DropdownItem
key="export-to-issue-manager"
isAriaDisabled={
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Adds the already exported check here.

key="export-to-issue-manager"
isDisabled={
migrationWave.applications?.length < 1
isTooltipEnabled={
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And here.

Signed-off-by: Ian Bolton <ibolton@redhat.com>
Copy link
Member

@djzager djzager left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ack

@ibolton336 ibolton336 merged commit a302446 into konveyor:main Feb 22, 2024
6 checks passed
@ibolton336 ibolton336 deleted the mta-1845 branch February 26, 2024 18:53
ibolton336 added a commit to ibolton336/tackle2-ui that referenced this pull request Feb 27, 2024
…onveyor#1691)

Resolves https://issues.redhat.com/browse/MTA-1845
After discussions with UXD ( @JustinXHale ), determined that this export
functionality can safely be disabled when no apps are available to
export. Apps that have already been exported already are assigned to a
ticket and Jira and cannot be re-exported until they are unlinked.

 
<img width="351" alt="Screenshot 2024-02-16 at 3 49 30 PM"
src="https://github.com/konveyor/tackle2-ui/assets/11218376/b432205b-98c6-42a2-8950-2132cbd41152">

Signed-off-by: Ian Bolton <ibolton@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants