Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

📖 Update developer documentation #1726

Merged
merged 4 commits into from
Mar 11, 2024
Merged

📖 Update developer documentation #1726

merged 4 commits into from
Mar 11, 2024

Conversation

rszwajko
Copy link
Collaborator

Changes:

  1. fix dead links i.e. to PF4 components or refactored code
  2. in README
    1. OLM addon issue
    2. be more general about minikube drivers i.e. rootless or without VMs
    3. prefer port forwarding to proxy when accessing dashboard (seems safer)
  3. in INTERNATIONALIZATION - comment that questionnaire is data imported from YAML files

@rszwajko rszwajko marked this pull request as draft February 29, 2024 18:43
@rszwajko
Update developer documentation
2f5d9d4 
Changes:
1. fix dead links i.e. to PF4 components or refactored code
2. in README
   a) OLM addon issue
   b) be more general about minikube drivers i.e. rootless
      or without VMs
   c) prefer port forwarding to proxy when accessing
      dashboard (seems safer)
3. in INTERNATIONALIZATION - comment that questionnaire is data
   imported from YAML files

Signed-off-by: Radoslaw Szwajkowski <rszwajko@redhat.com>
@rszwajko rszwajko marked this pull request as ready for review March 6, 2024 14:50
ibolton336
ibolton336 requested changes Mar 7, 2024
View reviewed changes
Copy link
Member

@ibolton336 ibolton336 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you so much for going through this, Radek. Just a few tweaks requested. Nice work!

INTERNATIONALIZATION.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Show resolved Hide resolved
README.md Show resolved Hide resolved
README.md Show resolved Hide resolved
README.md Show resolved Hide resolved
development.md Show resolved Hide resolved
sjd78
sjd78 reviewed Mar 8, 2024
View reviewed changes
Copy link
Member

@sjd78 sjd78 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • 👍 for link fixes
  • 👍 for the minikube dashboard access via port-forward
  • 👍 for the install and OLM install changes
  • Ian's suggestions look good as well

README.md Outdated Show resolved Hide resolved
rszwajko and others added 2 commits March 8, 2024 21:11
@rszwajko @ibolton336
Update INTERNATIONALIZATION.md
b61775e 
Co-authored-by: Ian Bolton <ibolton@redhat.com>
Signed-off-by: Radoslaw Szwajkowski <64194103+rszwajko@users.noreply.github.com>
@rszwajko @ibolton336
Update README.md
cd6ffa3 
Co-authored-by: Ian Bolton <ibolton@redhat.com>
Signed-off-by: Radoslaw Szwajkowski <64194103+rszwajko@users.noreply.github.com>
@ibolton336 ibolton336 merged commit 6b805b5 into konveyor:main Mar 11, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ibolton336 ibolton336 ibolton336 approved these changes

@mturley mturley Awaiting requested review from mturley

@sjd78 sjd78 Awaiting requested review from sjd78 sjd78 is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rszwajko @sjd78 @ibolton336