🌱 Refactor ReviewFields
#1752
Merged
🌱 Refactor ReviewFields
#1752
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Refactor the `ReviewFields` component:
- The component is used on the Review tab of application and
archetype details drawer
- The input prop `reviews` was not used in any current containing
component. Push the `useFetchReviews()` hook down to the component
itself. This keeps the data fetch as close as possible to where
it is used.
- Move the component to `@app/components/detail-drawer` folder
since it is used in more than one page grouping
Refactoring in advance of konveyor#1745
Signed-off-by: Scott J Dickerson <sdickers@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor the
ReviewFieldscomponent in advance of #1745:The component is used on the Review tab of application and archetype details drawer
The input prop
reviewswas not used in any current containing component. Push theuseFetchReviews()hook down to the component itself. This keeps the data fetch as close as possible to where it is used.Move the component to
@app/components/detail-drawerfolder since it is used in more than one page grouping