🐛 Fix insecure toggle regression #1831
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Key points: 1. do not extend PF SelectOptionProps interface - this allows to add custom props to the interface and provides better control what prop are forwarded to SelectOption 2. remove key prop as it's a special prop used internally by React 3. use value prop according to PF documentation - effectively replace previously used key prop 4. add label prop - to be used as human friendly representation of the value 5. add groupLabel prop 6. add chipLabel prop - for cases where it differs from the label prop (main use case are tag items) Signed-off-by: Radoslaw Szwajkowski <rszwajko@redhat.com> Signed-off-by: Ian Bolton <ibolton@redhat.com>
Signed-off-by: Ian Bolton <ibolton@redhat.com>
sjd78
approved these changes
Apr 9, 2024
ibolton336
added a commit
to ibolton336/tackle2-ui
that referenced
this pull request
Apr 10, 2024
Resolves https://issues.redhat.com/browse/MTA-2426 --------- Signed-off-by: Radoslaw Szwajkowski <rszwajko@redhat.com> Signed-off-by: Ian Bolton <ibolton@redhat.com> Co-authored-by: Radoslaw Szwajkowski <rszwajko@redhat.com>
ibolton336
added a commit
that referenced
this pull request
Apr 10, 2024
sjd78
added a commit
to sjd78/tackle2-ui
that referenced
this pull request
Apr 11, 2024
On the review form, fix the `onChange` handler for the following `NumberInput` fields: - criticality - priority Note: This fix is a follow up to the fix in konveyor#1831. A grep across the codebase showed 2 more or the same problems. Signed-off-by: Scott J Dickerson <sdickers@redhat.com>
sjd78
added a commit
to sjd78/tackle2-ui
that referenced
this pull request
Apr 11, 2024
On the review form, fix the `onChange` handler for the following `NumberInput` fields: - criticality - priority Note: This fix is a follow up to the fix in konveyor#1831. A grep across the codebase showed 2 more or the same problems. Signed-off-by: Scott J Dickerson <sdickers@redhat.com>
sjd78
added a commit
that referenced
this pull request
Apr 15, 2024
On the review form, fix the `onChange` handler for the following `NumberInput` fields: - criticality - priority Note: This fix is a follow up to the fix in #1831. A grep across the codebase showed 2 more or the same problems. Resolves: #1844 Signed-off-by: Scott J Dickerson <sdickers@redhat.com> Co-authored-by: Ian Bolton <ibolton@redhat.com>
github-actions bot
pushed a commit
that referenced
this pull request
Apr 15, 2024
On the review form, fix the `onChange` handler for the following `NumberInput` fields: - criticality - priority Note: This fix is a follow up to the fix in #1831. A grep across the codebase showed 2 more or the same problems. Resolves: #1844 Signed-off-by: Scott J Dickerson <sdickers@redhat.com> Co-authored-by: Ian Bolton <ibolton@redhat.com> Signed-off-by: Cherry Picker <noreply@github.com>
sjd78
pushed a commit
that referenced
this pull request
Apr 15, 2024
On the review form, fix the `onChange` handler for the following `NumberInput` fields: - criticality - priority Note: This fix is a follow up to the fix in #1831. A grep across the codebase showed 2 more of the same problems. Resolves: #1844 Backport-of: #1839 Signed-off-by: Scott J Dickerson <sdickers@redhat.com> Co-authored-by: Ian Bolton <ibolton@redhat.com> Signed-off-by: Cherry Picker <noreply@github.com>
This was referenced May 8, 2024
This was referenced Jun 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves https://issues.redhat.com/browse/MTA-2426