🐛 Switch sidebar type based on routes

[rszwajko]

Linked changes:

1. fix incorrect handling of Paths.assessment and Paths.questionnaire - both were incorrectly handled as dev routes
2. split Paths enum into type safe specialized readonly objects - DevPaths, AdminPaths and GeneralPaths

Resolves: #954

[ibolton336]

LGTM

[sjd78]

I like it so far, but I have a suggestion around the targetPath prop.

[sjd78]

I did find a strange behavior:

screencast-localhost_9000-2024.05.02-17_05_10.mp4

[sjd78]

LGTM

Working from the AdminPaths and GeneralPaths constants through types and back out to the sidebar makes sense to me. Typescript should raise enough alarms if something is done that doesn't line up properly that the change is worth it.

[codecov]

Codecov Report

Attention: Patch coverage is 38.29787% with 29 lines in your changes are missing coverage. Please review.

Project coverage is 41.22%. Comparing base (b654645) to head (e1c8527).
Report is 135 commits behind head on main.

Files	Patch %	Lines
client/src/app/layout/SidebarApp/SidebarApp.tsx	23.68%	29 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #1889      +/-   ##
==========================================
+ Coverage   39.20%   41.22%   +2.02%     
==========================================
  Files         146      158      +12     
  Lines        4857     5189     +332     
  Branches     1164     1269     +105     
==========================================
+ Hits         1904     2139     +235     
- Misses       2939     3032      +93     
- Partials       14       18       +4     

Flag	Coverage Δ
client	41.22% <38.29%> (+2.02%)	⬆️
server	?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.