🌱 Add and allow test image builds for more changes #1926
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sjd78
added
cherry-pick/release-0.3
Changes:
- If a `package.json` file changes, test the image builds. We
want to make sure that changes to the `engine` or `script` blocks
receive a through image build testing.
- Update the npm version check to `>=9.5.0`. This will allow
the test image build CI to check new builder images that also
have npm major version updates.
Signed-off-by: Scott J Dickerson <sdickers@redhat.com>
sjd78
force-pushed
the
build_dockerfile_tweak
branch
from
003437a
to
164623e
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1926 +/- ##
==========================================
+ Coverage 39.20% 42.10% +2.90%
==========================================
Files 146 163 +17
Lines 4857 5235 +378
Branches 1164 1275 +111
==========================================
+ Hits 1904 2204 +300
- Misses 2939 3015 +76
- Partials 14 16 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
rszwajko
approved these changes
May 29, 2024
github-actions bot
pushed a commit
that referenced
this pull request
May 29, 2024
Changes:
- If any of the `package.json` files change, test the image builds. We
want to make sure that changes to the `engine` or `script` blocks
receive a full image build testing.
- Update the npm version check to `>=9.5.0`. This will allow the test
image build CI to check new builder images that also have npm major
version updates.
Signed-off-by: Scott J Dickerson <sdickers@redhat.com>
Signed-off-by: Cherry Picker <noreply@github.com>
sjd78
added a commit
to sjd78/tackle2-ui
that referenced
this pull request
May 29, 2024
…nges (konveyor#1926) Changes: - If any of the `package.json` files change, test the image builds. We want to make sure that changes to the `engine` or `script` blocks receive a full image build testing. - Update the npm version check to `>=9.5.0`. This will allow the test image build CI to check new builder images that also have npm major version updates. Backport-of: konveyor#1926 Signed-off-by: Scott J Dickerson <sdickers@redhat.com>
sjd78
added a commit
that referenced
this pull request
May 29, 2024
…nges (#1926) (#1928) Changes: - If any of the `package.json` files change, test the image builds. We want to make sure that changes to the `engine` or `script` blocks receive a full image build testing. - Update the npm version check to `>=9.5.0`. This will allow the test image build CI to check new builder images that also have npm major version updates. Backport-of: #1926 Signed-off-by: Scott J Dickerson <sdickers@redhat.com>
sjd78
pushed a commit
that referenced
this pull request
May 29, 2024
…nges (#1926) (#1927) Changes: - If any of the `package.json` files change, test the image builds. We want to make sure that changes to the `engine` or `script` blocks receive a full image build testing. - Update the npm version check to `>=9.5.0`. This will allow the test image build CI to check new builder images that also have npm major version updates. Backport-of: #1926 Signed-off-by: Scott J Dickerson <sdickers@redhat.com> Signed-off-by: Cherry Picker <noreply@github.com>
rszwajko
added a commit
to rszwajko/tackle2-ui
that referenced
this pull request
Jun 5, 2024
Reference-Url: konveyor#1926 Signed-off-by: Radoslaw Szwajkowski <rszwajko@redhat.com>
rszwajko
added a commit
that referenced
this pull request
Jun 6, 2024
Reference-Url: #1926 Signed-off-by: Radoslaw Szwajkowski <rszwajko@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
If any of the
package.jsonfiles change, test the image builds. We want to make sure that changes to theengineorscriptblocks receive a full image build testing.Update the npm version check to
>=9.5.0. This will allow the test image build CI to check new builder images that also have npm major version updates.