Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ Add mvn:// prefix to application binary value in post request #1968

Merged
merged 3 commits into from
Jun 20, 2024

Conversation

ibolton336
Copy link
Member

Resolves: #1967

Note: validation is not necessary since the ui already breaks up the input into separate for fields and composes the binary coordinates under the hood.

Signed-off-by: Ian Bolton <ibolton@redhat.com>
Signed-off-by: Ian Bolton <ibolton@redhat.com>
Copy link

codecov bot commented Jun 19, 2024

Codecov Report

Attention: Patch coverage is 33.33333% with 6 lines in your changes missing coverage. Please review.

Project coverage is 42.73%. Comparing base (b654645) to head (e0543d8).
Report is 166 commits behind head on main.

Files Patch % Lines
...s/components/application-form/application-form.tsx 33.33% 6 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1968      +/-   ##
==========================================
+ Coverage   39.20%   42.73%   +3.53%     
==========================================
  Files         146      166      +20     
  Lines        4857     5263     +406     
  Branches     1164     1263      +99     
==========================================
+ Hits         1904     2249     +345     
- Misses       2939     2998      +59     
- Partials       14       16       +2     
Flag Coverage Δ
client 42.73% <33.33%> (+3.53%) ⬆️
server ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sjd78 sjd78 added this to the v0.5.0 milestone Jun 19, 2024
Copy link
Member

@sjd78 sjd78 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

✨ Prefix application binary coordinates with mvn://.
3 participants