🐛 Add tooltips for Priority and Preemption columns #2005
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2005 +/- ##
==========================================
+ Coverage 39.20% 42.19% +2.99%
==========================================
Files 146 171 +25
Lines 4857 5479 +622
Branches 1164 1309 +145
==========================================
+ Hits 1904 2312 +408
- Misses 2939 3151 +212
- Partials 14 16 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
sjd78
requested changes
Jul 10, 2024
Signed-off-by: Radoslaw Szwajkowski <rszwajko@redhat.com>
|
|
mguetta1
reviewed
Jul 14, 2024
| @@ -510,6 +510,10 @@ | |||
| "save": "Failed to save {{type}}." | |||
| } | |||
| }, | |||
| "tooltip": { | |||
| "priority": "Tasks priority(Low-High). Impacts tasks scheduling policy.", | |||
There was a problem hiding this comment.
Hi, I am not sure about this description regarding the priority value. The values can range from zero to any positive whole number.
Low-High doesn't say much to me. wdyt?
There was a problem hiding this comment.
Suggestion: Please use something like: Tasks priority, 0 to any positive integer (Low-High). Impacts tasks scheduling policy. as the tooltip
This was referenced Jul 17, 2024
sjd78
added a commit
that referenced
this pull request
Jul 25, 2024
Update the tooltip for the priority column to be more descriptive. Resolves: https://issues.redhat.com/browse/MTA-3235 Follow-up: #2005 Signed-off-by: Scott J Dickerson <sdickers@redhat.com>
This was referenced Jul 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves: https://issues.redhat.com/browse/MTA-3235