Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Address targets falling out of sync after label selection changes #2019

Merged
merged 1 commit into from
Jul 22, 2024

Conversation

ibolton336
Copy link
Member

Resolves: https://issues.redhat.com/browse/MTA-3180

  • Currently, the set-options screen allows edit of target labels which can be set manually on the Advanced options step or by way of selecting a target card on the target card step. This PR brings the form labels and selectedTarget form values in sync by updating the selected targets to reflect any form label changes in the set options page. This fixes the mta-3180 scenario by causing validation to reflect the now accurate state of the selectedTargets form value.
selectedtargetsfix.mov

Signed-off-by: Ian Bolton <ibolton@redhat.com>
Copy link

codecov bot commented Jul 17, 2024

Codecov Report

Attention: Patch coverage is 13.79310% with 50 lines in your changes missing coverage. Please review.

Project coverage is 42.07%. Comparing base (b654645) to head (a2a142a).
Report is 195 commits behind head on main.

Files Patch % Lines
...rc/app/pages/applications/analysis-wizard/utils.ts 13.33% 39 Missing ⚠️
...pages/applications/analysis-wizard/set-options.tsx 9.09% 10 Missing ⚠️
...pages/applications/analysis-wizard/set-targets.tsx 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2019      +/-   ##
==========================================
+ Coverage   39.20%   42.07%   +2.87%     
==========================================
  Files         146      171      +25     
  Lines        4857     5511     +654     
  Branches     1164     1313     +149     
==========================================
+ Hits         1904     2319     +415     
- Misses       2939     3176     +237     
- Partials       14       16       +2     
Flag Coverage Δ
client 42.07% <13.79%> (+2.87%) ⬆️
server ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ibolton336 ibolton336 closed this Jul 18, 2024
@ibolton336 ibolton336 reopened this Jul 18, 2024
Copy link
Member

@sjd78 sjd78 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants