Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🐛 Fix fetching in InfiniteScroller #2085

Merged
merged 3 commits into from
Sep 14, 2024
Merged

🐛 Fix fetching in InfiniteScroller #2085

merged 3 commits into from
Sep 14, 2024

Conversation

rszwajko
Copy link
Collaborator

@rszwajko rszwajko commented Sep 10, 2024 •
edited
Loading

Fixes:

  1. initial delay in first fetch - root cause was delayed initialization of sentinel reference
  2. extra page fetch request - algorithm based on items count was not sufficient

Reference-Url: #2049

@codecov Codecov
Copy link

codecov bot commented Sep 10, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 7.69231% with 12 lines in your changes missing coverage. Please review.

Project coverage is 42.14%. Comparing base (b654645) to head (e13c049).
Report is 235 commits behind head on main.

Files with missing lines Patch % Lines
...p/components/InfiniteScroller/InfiniteScroller.tsx 12.50% 7 Missing ⚠️
...mponents/InfiniteScroller/useVisibilityTracker.tsx 0.00% 4 Missing ⚠️
.../app/components/task-manager/TaskManagerDrawer.tsx 0.00% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #2085      +/-   ##
==========================================
+ Coverage   39.20%   42.14%   +2.94%     
==========================================
  Files         146      174      +28     
  Lines        4857     5578     +721     
  Branches     1164     1374     +210     
==========================================
+ Hits         1904     2351     +447     
- Misses       2939     3211     +272     
- Partials       14       16       +2
Flag Coverage Δ
client 42.14% <7.69%> (+2.94%) ⬆️
server ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rszwajko rszwajko changed the title ✨ Improve fetching in InfiniteScroller 🐛 Fix fetching in InfiniteScroller Sep 10, 2024
@rszwajko
Improve fetching in InfiniteScroller
e001615 
Signed-off-by: Radoslaw Szwajkowski <rszwajko@redhat.com>
@rszwajko rszwajko marked this pull request as ready for review September 10, 2024 18:24
sjd78
sjd78 approved these changes Sep 13, 2024
View reviewed changes
Copy link
Member

@sjd78 sjd78 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sjd78 sjd78 merged commit 0d87a57 into konveyor:main Sep 14, 2024
12 checks passed
Shevijacobson pushed a commit to Shevijacobson/tackle2-ui that referenced this pull request Sep 18, 2024
@rszwajko @sjd78 @Shevijacobson
🐛 Fix fetching in InfiniteScroller (konveyor#2085)
ceb827e 
Fixes:
1. initial delay in first fetch - root cause was delayed initialization
of sentinel reference

2. extra page fetch request - algorithm based on items count was not
sufficient
 
Reference-Url:  konveyor#2049

Signed-off-by: Radoslaw Szwajkowski <rszwajko@redhat.com>
Co-authored-by: Scott Dickerson <sdickers@redhat.com>
Shevijacobson pushed a commit to Shevijacobson/tackle2-ui that referenced this pull request Sep 18, 2024
@rszwajko @sjd78 @Shevijacobson
🐛 Fix fetching in InfiniteScroller (konveyor#2085)
6d9c837 
Fixes:
1. initial delay in first fetch - root cause was delayed initialization
of sentinel reference

2. extra page fetch request - algorithm based on items count was not
sufficient

Reference-Url:  konveyor#2049

Signed-off-by: Radoslaw Szwajkowski <rszwajko@redhat.com>
Co-authored-by: Scott Dickerson <sdickers@redhat.com>
Signed-off-by: Shevijacobson <shevijacob@gmail.com>
DvoraShechter1 pushed a commit to DvoraShechter1/tackle2-ui that referenced this pull request Sep 19, 2024
@rszwajko @sjd78 @DvoraShechter1
🐛 Fix fetching in InfiniteScroller (konveyor#2085)
a3d7a85 
Fixes:
1. initial delay in first fetch - root cause was delayed initialization
of sentinel reference

2. extra page fetch request - algorithm based on items count was not
sufficient

Reference-Url:  konveyor#2049

Signed-off-by: Radoslaw Szwajkowski <rszwajko@redhat.com>
Co-authored-by: Scott Dickerson <sdickers@redhat.com>
Signed-off-by: DvoraShechter1 <d0583212560@gmail.com>
DvoraShechter1 pushed a commit to DvoraShechter1/tackle2-ui that referenced this pull request Sep 19, 2024
@rszwajko @sjd78 @DvoraShechter1
🐛 Fix fetching in InfiniteScroller (konveyor#2085)
f766953 
Fixes:
1. initial delay in first fetch - root cause was delayed initialization
of sentinel reference

2. extra page fetch request - algorithm based on items count was not
sufficient

Reference-Url:  konveyor#2049

Signed-off-by: Radoslaw Szwajkowski <rszwajko@redhat.com>
Co-authored-by: Scott Dickerson <sdickers@redhat.com>
Signed-off-by: DvoraShechter1 <d0583212560@gmail.com>
HadasahR pushed a commit to HadasahR/tackle2-ui that referenced this pull request Sep 24, 2024
@rszwajko @sjd78 @HadasahR
🐛 Fix fetching in InfiniteScroller (konveyor#2085)
e8fc837 
Fixes:
1. initial delay in first fetch - root cause was delayed initialization
of sentinel reference

2. extra page fetch request - algorithm based on items count was not
sufficient

Reference-Url:  konveyor#2049

Signed-off-by: Radoslaw Szwajkowski <rszwajko@redhat.com>
Co-authored-by: Scott Dickerson <sdickers@redhat.com>
Signed-off-by: HadasahR <d025834828@gmail.com>
@rszwajko rszwajko mentioned this pull request Sep 26, 2024
Open
This was referenced Oct 1, 2024
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sjd78 sjd78 sjd78 approved these changes

@ibolton336 ibolton336 Awaiting requested review from ibolton336 ibolton336 is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rszwajko @sjd78