✨ Add edit icon with ActionColumns property in the Archetypes table #2098
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Shevijacobson
force-pushed
the
m_s_ar-table
branch
3 times, most recently
from
a0d63b6
to
b14dceb
Compare
Signed-off-by: Shevijacobson <shevijacob@gmail.com>
Shevijacobson
force-pushed
the
m_s_ar-table
branch
from
18463e3
to
abcc5ce
Compare
mguetta1
requested review from
ibolton336,
sjd78 and
rszwajko
as code owners
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2098 +/- ##
==========================================
+ Coverage 39.20% 41.97% +2.77%
==========================================
Files 146 175 +29
Lines 4857 5629 +772
Branches 1164 1415 +251
==========================================
+ Hits 1904 2363 +459
- Misses 2939 3145 +206
- Partials 14 121 +107
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Signed-off-by: Shevijacobson <shevijacob@gmail.com>
Shevijacobson
force-pushed
the
m_s_ar-table
branch
from
5b2c945
to
c9dd6fa
Compare
rszwajko
reviewed
Sep 26, 2024
There was a problem hiding this comment.
Code looks good! 2 minor comments:
- it would be nice to rephrase PR title to better reflect the change - it will be used as git commit title and stay in the repo history forever:)
- if the change has some visual effect it's also nice to add before/after screenshots in a separate
commitcomment.
|
@mguetta1 |
Shevijacobson
changed the title
Shevijacobson
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes Made:
Removed the edit action from the ActionsColumn.
Added a dedicated edit icon outside the ActionsColumn, providing a clearer and more focused user interface.
Part of #1318
Before the change:
After the change: