feat(table): components theming with CSS-vars (#DS-2843) #275
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Visit the preview URL for this PR (updated for commit dc12e52): https://koobiq-next--prs-275-2ul7p6pp.web.app (expires Tue, 17 Sep 2024 16:53:19 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: c9e37e518febda70d0317d07e8ceb35ac43c534c |
NikGurev
requested changes
Sep 12, 2024
| @@ -100,7 +100,7 @@ | |||
| --kbq-badge-outline-fade-on-theme-icon: hsla(216, 100%, 50%, 100%); | |||
| --kbq-badge-outline-fade-on-contrast-background: transparent; | |||
| --kbq-badge-outline-fade-on-contrast-color: hsla(229, 15%, 15%, 100%); | |||
| --kbq-badge-outline-fade-on-contrast-border: hsla(229, 15%, 80%, 100%); | |||
| --kbq-badge-outline-fade-on-contrast-border: hsla(229, 15%, 70%, 100%); | |||
There was a problem hiding this comment.
Suggested change
| --kbq-badge-outline-fade-on-contrast-border: hsla(229, 15%, 70%, 100%); | |
| --kbq-badge-outline-fade-on-contrast-border: hsla(229, 15%, 80%, 100%); |
There was a problem hiding this comment.
вот тут не совсем понял, этот же файл с токенами сам генерится)
There was a problem hiding this comment.
предлагаю просто ревертнуть, чтобы лишних изменений не было
NikGurev
approved these changes
Sep 12, 2024
sk8knut
added a commit
that referenced
this pull request
Sep 17, 2024
…nto feat/DS-2835 * 'feat/DS-2835' of github.com:koobiq/angular-components: fix(form-field): kbq-password-hint error (#DS-2868) (#277) feat(tooltip): components theming with CSS-vars (#DS-2840) (#279) feat(file-upload): components theming with CSS-vars (#DS-2812) (#273) feat(description-list): components theming with CSS-vars (#DS-2846) (#274) feat(tree-select): components theming with CSS-vars (#DS-2841) (#278) feat(empty-state): components theming with CSS-vars (#DS-2811) (#272) feat(code-block): components theming with CSS-vars (#DS-2806) (#271) feat(table): components theming with CSS-vars (#DS-2843) (#275) feat(toggle): components theming with CSS-vars (#DS-2839) (#280) feat(toast): components theming with CSS-vars (#DS-2837) (#281) feat(docs): theme switch refactoring (#DS-2796) (#266)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.