Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(visual,docs): moved from sass vars to css-vars #296

Draft
wants to merge 9 commits into
base: main
Choose a base branch
from

Conversation

NikGurev
Copy link
Contributor

@NikGurev NikGurev commented Sep 19, 2024

Summary

Implemented theming with css-vars in components and docs.

List of notable changes:

  • Replaced absolute value with custom css-var in components
  • Replaced custom components with css-vars theming
  • Removed components css-vars from docs tokens

BREAKING CHANGES:
use css-tokens.css, css-tokens-light.css, css-tokens-dark.css for theming

TODO:

  • update docs

@NikGurev NikGurev added documentation Improvements or additions to documentation enhancement New feature or request breaking changes labels Sep 19, 2024
@NikGurev NikGurev self-assigned this Sep 19, 2024
@NikGurev NikGurev changed the base branch from feat/DS-2833 to main September 19, 2024 09:53
Copy link

github-actions bot commented Sep 19, 2024

Visit the preview URL for this PR (updated for commit de06ec7):

https://koobiq-next--prs-296-fqdthfzu.web.app

(expires Tue, 24 Sep 2024 10:22:14 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: c9e37e518febda70d0317d07e8ceb35ac43c534c

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking changes documentation Improvements or additions to documentation enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants