Fixes for Android / Termux #62
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sholderbach
added a commit
to sholderbach/nushell
that referenced
this pull request
May 4, 2024
sholderbach
added a commit
to nushell/nushell
that referenced
this pull request
May 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix the following issues for Android:
std::os::linuxwas assumed to be available, but it's actuallystd::os::android/tmpis used as the base path by default, butTMPDIRmust be used on Termuxc_charwas assumed to bei8, but it's actuallyu8on aarch64Can confirm that the tests pass with this patch under Termux on both x86_64 and aarch64. I have not tested 32-bit architectures.