Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Timestamps for the kitty video #6321

Merged
merged 2 commits into from
May 31, 2023
Merged

Timestamps for the kitty video #6321

merged 2 commits into from
May 31, 2023

Conversation

waikoo
Copy link
Contributor

@waikoo waikoo commented May 31, 2023

Originally discussed in #6281, this pull request adds timestamps under the introductory kitty video.

Its purpose is to give a better overview in navigating and comprehending the video.

Timestamps can be edited and expanded upon using timestamps_source.js and the ARRAY object in timestamps.js to get styling.
A separate stylesheet is used with the timestamps namespace to differentiate itself from other parts of the code.
conf.py is modified to include the new files needed to generate the new element and to specify the script being a module to be able to use a separate source file (timestamps_source.js).

To mitigate potential security vulnerabilities associated with using innerHTML and similar methods, this pull request intentionally creates and manipulates elements dynamically through JavaScript, ensuring a safer and controlled approach to adding timestamps under the introductory kitty video.

Additionally, this implementation ensures seamless functionality in both light and dark modes, providing a consistent user experience across different viewing environments.

Thanks to @kovidgoyal for the guidance.

@kovidgoyal kovidgoyal merged commit d919864 into kovidgoyal:master May 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants