Attempt to fix handling of rcs init command

If a store does not exist, then it should be initialized with the `init`
command.  The purpose of the `rcs init` command is to initialize a Git
repository in an existing "fs" store that has no revision control, so
we won't get the desired result if we fail the init, or if we just do
nothing, when the store is using the "fs" backend.  It also makes no
sense to check the backend for the context because that is initialized
from the root store only, and the actual storage could be different if
the "--store" option was used.

internal/action/init.go

@@ -142,12 +142,12 @@ func (s *Action) init(ctx context.Context, alias, path string, keys ...string) e
 		}
 	}
 
-	if backend.HasStorageBackend(ctx) {
-		bn := backend.StorageBackendName(backend.GetStorageBackend(ctx))
-		debug.Log("Initializing RCS (%s)...", bn)
+	be := backend.GetStorageBackend(ctx)
+	if be == backend.GitFS {
+		debug.Log("Initializing git repository...")
 		if err := s.rcsInit(ctx, alias, ctxutil.GetUsername(ctx), ctxutil.GetEmail(ctx)); err != nil {
 			debug.Log("Stacktrace: %+v\n", err)
-			out.Errorf(ctx, "✗ Failed to init Version Control (%s): %s", bn, err)
+			out.Errorf(ctx, "✗ Failed to initialize git repository: %s", err)
 		}
 		debug.Log("RCS initialized as %s", s.Store.Storage(ctx, alias).Name())
 	} else {

internal/action/rcs.go

@@ -38,17 +38,10 @@ func (s *Action) RCSInit(c *cli.Context) error {
 }
 
 func (s *Action) rcsInit(ctx context.Context, store, un, ue string) error {
-	be := backend.GetStorageBackend(ctx)
-	// TODO this should rather ask s.Store if it HasRCSInit or something.
-	if be == backend.FS {
-		return nil
-	}
-
-	bn := backend.StorageBackendName(be)
 	userName, userEmail := s.getUserData(ctx, store, un, ue)
 	if err := s.Store.RCSInit(ctx, store, userName, userEmail); err != nil {
 		if errors.Is(err, backend.ErrNotSupported) {
-			debug.Log("RCSInit not supported for backend %s in %q", bn, store)
+			debug.Log("RCSInit not supported for storage backend in %q", store)
 
 			return nil
 		}
@@ -60,7 +53,7 @@ func (s *Action) rcsInit(ctx context.Context, store, un, ue string) error {
 		return fmt.Errorf("failed to run git init: %w", err)
 	}
 
-	out.Printf(ctx, "Initialized git repository for %q <%s>...", un, ue)
+	out.Printf(ctx, "Initialized git repository for %q <%s>...", userName, userEmail)
 
 	return nil
 }

internal/store/leaf/rcs.go

@@ -14,7 +14,8 @@ import (
 
 // GitInit initializes the git storage.
 func (s *Store) GitInit(ctx context.Context) error {
-	storage, err := backend.InitStorage(ctx, backend.GetStorageBackend(ctx), s.path)
+	// The desired storage type for `GitInit` is always GitFS.
+	storage, err := backend.InitStorage(ctx, backend.GitFS, s.path)
 	if err != nil {
 		return err
 	}

main_test.go

@@ -78,7 +78,6 @@ var commandsWithError = set.Map([]string{
 	".move",
 	".otp",
 	".process",
-	".rcs.status",
 	".recipients.add",
 	".recipients.remove",
 	".show",