Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip test_multiple_bind_addresses_port_forward on macOS #383

Merged

Conversation

jacobtomlinson
Copy link
Member

Workaround for #380 to avoid folks on Mac having to exclude a test that hangs.

Copy link

codecov bot commented May 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.25%. Comparing base (87063fc) to head (2d5f8e5).
Report is 100 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #383      +/-   ##
==========================================
+ Coverage   94.61%   95.25%   +0.63%     
==========================================
  Files          29       29              
  Lines        3141     3413     +272     
==========================================
+ Hits         2972     3251     +279     
+ Misses        169      162       -7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jacobtomlinson jacobtomlinson merged commit a676fab into kr8s-org:main May 21, 2024
12 checks passed
@jacobtomlinson jacobtomlinson deleted the skip-multi-port-test-on-macos branch May 21, 2024 16:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant