Fix listing all namespaces when base URL is specified #424
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jacobtomlinson
added
bug
jacobtomlinson
commented
Jul 1, 2024
| @@ -130,7 +131,7 @@ def _construct_url( | |||
| parts = [base] | |||
| if version: | |||
| parts.append(version) | |||
| if namespace is not None: | |||
| if namespace: | |||
There was a problem hiding this comment.
When using a URL with a base url component and setting namespace=kr8s.ALL this can end up as an empty string. So modifying the if statement to catch that case.
jacobtomlinson
commented
Jul 1, 2024
| @@ -111,6 +111,7 @@ async def _create_session(self) -> None: | |||
| headers=headers, | |||
| verify=await self.auth.ssl_context(), | |||
| timeout=self._timeout, | |||
| follow_redirects=True, | |||
There was a problem hiding this comment.
If a baseurl is set we may get redirected. By default httpx doesn't follow redirects, but we probably always want to.
jacobtomlinson
force-pushed
the
fix-baseurl
branch
from
dcbb55d
to
75ac962
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #424 +/- ##
==========================================
+ Coverage 94.61% 95.27% +0.65%
==========================================
Files 29 30 +1
Lines 3141 3661 +520
==========================================
+ Hits 2972 3488 +516
- Misses 169 173 +4 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the issues covered in #284. When specifying the baseurl of a server there seems to be a couple of problems with constructing the API urls.
I also noticed that when setting
kr8s.api(url="...")the load kubeconfig code is never called, so the default namespace is never loaded. I added a quick workaround for this so that we get the default namespace, but I'm not sure if this is correct behaviour. I'll open a new issue to explore this further.