Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correctly set plural name in get when looking up unknown resources #464

Merged
merged 2 commits into from
Aug 1, 2024

Conversation

jacobtomlinson
Copy link
Member

@jacobtomlinson jacobtomlinson commented Aug 1, 2024

Closes #460

Updates lookup_kind() to also return the plural form of the resource kind. Also updates get_kind() to pass that plural along to new_class() to ensure dynamic classes are created correctly.

@jacobtomlinson jacobtomlinson added bug Something isn't working kr8s labels Aug 1, 2024
@github-actions github-actions bot added the tests label Aug 1, 2024
Copy link

codecov bot commented Aug 1, 2024

Codecov Report

Attention: Patch coverage is 93.33333% with 1 line in your changes missing coverage. Please review.

Project coverage is 95.11%. Comparing base (87063fc) to head (7fc9a3b).
Report is 93 commits behind head on main.

Files Patch % Lines
kr8s/_api.py 75.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #464      +/-   ##
==========================================
+ Coverage   94.61%   95.11%   +0.49%     
==========================================
  Files          29       30       +1     
  Lines        3141     3889     +748     
==========================================
+ Hits         2972     3699     +727     
- Misses        169      190      +21     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jacobtomlinson jacobtomlinson merged commit 808a54a into kr8s-org:main Aug 1, 2024
11 checks passed
@jacobtomlinson jacobtomlinson deleted the unknown-type-plurals branch August 1, 2024 10:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working kr8s tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unknown objects ending with y cannot be fetched
1 participant