Check if embedded cert is base64 encoded before decoding #485
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #484
Instead of trying to base64 decode the certs and failing when they are stored in plain-text this PR checks if they are certs and only decodes them if they are.
This fixes configs which contain new lines in their base64 encoded data (which is technically not valid base64, but decodes fine).
This should not break folks who have plain text certs, which is what the previous try/except behaviour was enabling. Added a test to verify this.