Adding Proxy settings for private clusters #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paigerube14
force-pushed
the
proxy
branch
2 times, most recently
from
4eb1e3c
to
083b944
Compare
sandrobonazzola
force-pushed
the
proxy
branch
from
1e68b13
to
29c66d3
Compare
janosdebugs
suggested changes
Nov 10, 2022
arcaflow_plugin_kill_pod.py
Outdated
| @@ -13,20 +16,39 @@ | |||
| from kubernetes.client import ApiException, V1DeleteOptions, V1Pod, V1PodList | |||
|
|
|||
|
|
|||
| urllib3.disable_warnings() | |||
There was a problem hiding this comment.
Why are these warnings disabled? Please add a comment.
There was a problem hiding this comment.
And disabling all warnings is a path leading to not understanding bad behavior.
There was a problem hiding this comment.
Will remove, found how to update without needing this on a similar PR
I have made some updates but not successfully gotten things running on a private cluster
arcaflow_plugin_kill_pod.py
Outdated
| http_proxy = os.getenv("http_proxy", None) | ||
| """Proxy has auth header""" | ||
| if http_proxy and "@" in http_proxy: | ||
| proxy_auth = http_proxy.split("@")[0].split("//")[1] |
There was a problem hiding this comment.
Please use proper URL parsing instead of splitting the http_proxy. @ signs are valid components of usernames and passwords when escaped.
portante
suggested changes
Nov 10, 2022
arcaflow_plugin_kill_pod.py
Outdated
| @@ -13,20 +16,39 @@ | |||
| from kubernetes.client import ApiException, V1DeleteOptions, V1Pod, V1PodList | |||
|
|
|||
|
|
|||
| urllib3.disable_warnings() | |||
There was a problem hiding this comment.
And disabling all warnings is a path leading to not understanding bad behavior.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes introduced with this PR
Adding changes that allow private clusters to use this plugin
By contributing to this repository, I agree to the contribution guidelines.