Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace all usage of incr/decr with asc/desc as removed in 3.5.0 #228

Closed
krlawrence opened this issue Jul 27, 2021 · 1 comment
Closed

Replace all usage of incr/decr with asc/desc as removed in 3.5.0 #228

krlawrence opened this issue Jul 27, 2021 · 1 comment
Assignees
@krlawrence
Labels
consistency Fixed important improvements v283

Comments

@krlawrence
Copy link
Owner

krlawrence commented Jul 27, 2021 •
edited
Loading

The previously deprecated Order.incr and Order.decr were completely removed in TinkerPop 3.5.0. The manuscript needs to be updated to favor Order.asc and Order.desc and the note about the deprecation needs to be updated. As part of this change an introductory paragraph about TinkerPop 3.5.0 needs to be added.

Several files in the sample-code folder will also need updating.
@krlawrence krlawrence self-assigned this Jul 27, 2021
@krlawrence krlawrence mentioned this issue Jul 27, 2021
Open
krlawrence added a commit that referenced this issue Aug 1, 2021
@krlawrence
Replace incr/decr with asc/desc #228
1b71e93
krlawrence added a commit that referenced this issue Aug 1, 2021
@krlawrence
Remove use of incr/decr and update that discussion #228
92a4d8a
krlawrence added a commit that referenced this issue Aug 1, 2021
@krlawrence
Update Chapter 1 to introduce 3.5.x #228
b70a9d2
krlawrence added a commit that referenced this issue Aug 1, 2021
@krlawrence
Further as/desc related updates #228
34a8128
krlawrence added a commit that referenced this issue Aug 1, 2021
@krlawrence
Further asc/desc related updates #228
c9a39dc
krlawrence added a commit that referenced this issue Aug 2, 2021
@krlawrence
Allow version 3.5 to pass #228
6f2ac48
krlawrence added a commit that referenced this issue Aug 2, 2021
@krlawrence
Replace a desc that got missed before #228
5323de4
krlawrence added a commit that referenced this issue Aug 3, 2021
@krlawrence
Moved up to TinkerPop 3.5.1 #228
3aabeeb
krlawrence added a commit that referenced this issue Aug 3, 2021
@krlawrence
Fix typo #228
043f701
@krlawrence
Copy link
Owner Author

Closing as this is fixed and work has now started on the second edition. There will likely be one final release of the v283 first edition line before the V2 branch becomes the second edition. That release will include these fixes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@krlawrence krlawrence

Labels
consistency Fixed important improvements v283
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@krlawrence