Skip to content

Commit

Permalink
Updated dependencies and migration to androidx
Browse files Browse the repository at this point in the history
  • Loading branch information
kirill committed Mar 18, 2019
1 parent 5721b43 commit b05cee9
Show file tree
Hide file tree
Showing 30 changed files with 133 additions and 115 deletions.
4 changes: 2 additions & 2 deletions build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -9,13 +9,13 @@ buildscript {
}
}
dependencies {
classpath 'com.android.tools.build:gradle:3.1.0'
classpath 'com.android.tools.build:gradle:3.3.2'

// NOTE: Do not place your application dependencies here; they belong
// in the individual module build.gradle files
}
ext {
support = '27.1.0'
support = '1.1.0-aplha02'
constraints = '1.0.2'
}
}
Expand Down
4 changes: 3 additions & 1 deletion gradle.properties
Original file line number Diff line number Diff line change
Expand Up @@ -30,4 +30,6 @@ POM_LICENCE_NAME=The Apache Software License, Version 2.0
POM_LICENCE_URL=http://www.apache.org/licenses/LICENSE-2.0
POM_LICENCE_DIST=repo
POM_DEVELOPER_ID=yalantis
POM_DEVELOPER_NAME=Yalantis
POM_DEVELOPER_NAME=Yalantis
android.useAndroidX=true
android.enableJetifier=true
4 changes: 2 additions & 2 deletions gradle/wrapper/gradle-wrapper.properties
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
#Thu Apr 05 11:29:51 EEST 2018
#Mon Mar 18 17:38:53 EET 2019
distributionBase=GRADLE_USER_HOME
distributionPath=wrapper/dists
zipStoreBase=GRADLE_USER_HOME
zipStorePath=wrapper/dists
distributionUrl=https\://services.gradle.org/distributions/gradle-4.4-all.zip
distributionUrl=https\://services.gradle.org/distributions/gradle-4.10.1-all.zip
16 changes: 8 additions & 8 deletions sample/build.gradle
Original file line number Diff line number Diff line change
@@ -1,14 +1,14 @@
apply plugin: 'com.android.application'

android {
compileSdkVersion 27
buildToolsVersion '27.0.3'
compileSdkVersion 28
buildToolsVersion '28.0.3'
defaultConfig {
applicationId "com.yalantis.ucrop.sample"
minSdkVersion 14
targetSdkVersion 27
versionCode 11
versionName "1.2.3"
targetSdkVersion 28
versionCode 12
versionName "1.2.4"
}
flavorDimensions "default"
buildTypes {
Expand All @@ -35,8 +35,8 @@ android {
}

dependencies {
implementation "com.android.support:appcompat-v7:$support"
implementation "com.android.support:support-compat:$support"
implementation "com.android.support.constraint:constraint-layout:$constraints"
implementation "androidx.appcompat:appcompat:$support"
implementation "androidx.core:core:$support"
implementation 'androidx.constraintlayout:constraintlayout:1.1.3'
implementation project(':ucrop')
}
2 changes: 1 addition & 1 deletion sample/src/main/AndroidManifest.xml
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@
android:label="@string/app_name"
android:theme="@style/AppTheme">
<provider
android:name="android.support.v4.content.FileProvider"
android:name="androidx.core.content.FileProvider"
android:authorities="@string/file_provider_authorities"
android:exported="false"
android:grantUriPermissions="true">
Expand Down
11 changes: 6 additions & 5 deletions sample/src/main/java/com/yalantis/ucrop/sample/BaseActivity.java
Original file line number Diff line number Diff line change
@@ -1,11 +1,12 @@
package com.yalantis.ucrop.sample;

import android.content.DialogInterface;
import android.support.annotation.NonNull;
import android.support.annotation.Nullable;
import android.support.v4.app.ActivityCompat;
import android.support.v7.app.AlertDialog;
import android.support.v7.app.AppCompatActivity;

import androidx.annotation.NonNull;
import androidx.annotation.Nullable;
import androidx.appcompat.app.AlertDialog;
import androidx.appcompat.app.AppCompatActivity;
import androidx.core.app.ActivityCompat;

/**
* Created by Oleksii Shliama (https://github.com/shliama).
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -15,12 +15,6 @@
import android.os.Build;
import android.os.Bundle;
import android.os.Environment;
import android.support.annotation.NonNull;
import android.support.v4.app.ActivityCompat;
import android.support.v4.app.NotificationCompat;
import android.support.v4.content.FileProvider;
import android.support.v7.app.ActionBar;
import android.support.v7.widget.Toolbar;
import android.util.Log;
import android.view.Menu;
import android.view.MenuItem;
Expand All @@ -35,6 +29,13 @@
import java.util.Calendar;
import java.util.List;

import androidx.annotation.NonNull;
import androidx.appcompat.app.ActionBar;
import androidx.appcompat.widget.Toolbar;
import androidx.core.app.ActivityCompat;
import androidx.core.app.NotificationCompat;
import androidx.core.content.FileProvider;

import static android.content.Intent.FLAG_GRANT_READ_URI_PERMISSION;
import static android.content.Intent.FLAG_GRANT_WRITE_URI_PERMISSION;

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -11,13 +11,6 @@
import android.net.Uri;
import android.os.Build;
import android.os.Bundle;
import android.support.annotation.ColorInt;
import android.support.annotation.DrawableRes;
import android.support.annotation.NonNull;
import android.support.v4.app.ActivityCompat;
import android.support.v4.content.ContextCompat;
import android.support.v7.app.ActionBar;
import android.support.v7.widget.Toolbar;
import android.text.Editable;
import android.text.TextWatcher;
import android.util.Log;
Expand All @@ -43,6 +36,14 @@
import java.util.Locale;
import java.util.Random;

import androidx.annotation.ColorInt;
import androidx.annotation.DrawableRes;
import androidx.annotation.NonNull;
import androidx.appcompat.app.ActionBar;
import androidx.appcompat.widget.Toolbar;
import androidx.core.app.ActivityCompat;
import androidx.core.content.ContextCompat;

/**
* Created by Oleksii Shliama (https://github.com/shliama).
*/
Expand Down
2 changes: 1 addition & 1 deletion sample/src/main/res/layout/activity_result.xml
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
android:layout_height="match_parent"
android:orientation="vertical">

<android.support.v7.widget.Toolbar
<androidx.appcompat.widget.Toolbar
android:id="@+id/toolbar"
android:layout_width="match_parent"
android:layout_height="?attr/actionBarSize"
Expand Down
12 changes: 7 additions & 5 deletions sample/src/main/res/layout/activity_sample.xml
Original file line number Diff line number Diff line change
@@ -1,15 +1,17 @@
<?xml version="1.0" encoding="utf-8"?>
<android.support.constraint.ConstraintLayout xmlns:android="http://schemas.android.com/apk/res/android"
<androidx.constraintlayout.widget.ConstraintLayout xmlns:android="http://schemas.android.com/apk/res/android"
xmlns:app="http://schemas.android.com/apk/res-auto"
android:layout_width="match_parent"
android:layout_height="match_parent">

<android.support.v7.widget.Toolbar
<androidx.appcompat.widget.Toolbar
android:id="@+id/toolbar"
android:layout_width="match_parent"
android:layout_height="wrap_content"
android:minHeight="?attr/actionBarSize"
android:visibility="gone">
android:visibility="gone"
app:layout_constraintStart_toStartOf="parent"
app:layout_constraintTop_toTopOf="parent">

<TextView
android:id="@+id/toolbar_title"
Expand All @@ -18,7 +20,7 @@
android:layout_height="wrap_content"
android:layout_gravity="center" />

</android.support.v7.widget.Toolbar>
</androidx.appcompat.widget.Toolbar>

<FrameLayout
android:id="@+id/fragment_container"
Expand All @@ -33,4 +35,4 @@
android:id="@+id/settings"
layout="@layout/include_settings" />

</android.support.constraint.ConstraintLayout>
</androidx.constraintlayout.widget.ConstraintLayout>
12 changes: 6 additions & 6 deletions ucrop/build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -2,12 +2,12 @@ apply plugin: 'com.android.library'
apply from: '../mavenpush.gradle'

android {
compileSdkVersion 27
buildToolsVersion '27.0.3'
compileSdkVersion 28
buildToolsVersion '28.0.3'

defaultConfig {
minSdkVersion 14
targetSdkVersion 27
targetSdkVersion 28
versionCode 23
versionName "2.2.2-native"

Expand Down Expand Up @@ -36,7 +36,7 @@ android {
}

dependencies {
implementation 'com.android.support:appcompat-v7:27.1.0'
implementation 'com.android.support:exifinterface:27.1.0'
implementation 'com.squareup.okhttp3:okhttp:3.8.1'
implementation 'androidx.appcompat:appcompat:1.1.0-alpha02'
implementation 'androidx.exifinterface:exifinterface:1.1.0-alpha01'
implementation 'com.squareup.okhttp3:okhttp:3.11.0'
}
17 changes: 9 additions & 8 deletions ucrop/src/main/java/com/yalantis/ucrop/UCrop.java
Original file line number Diff line number Diff line change
Expand Up @@ -10,19 +10,20 @@
import android.os.Build;
import android.os.Bundle;
import android.os.Parcelable;
import android.support.annotation.ColorInt;
import android.support.annotation.DrawableRes;
import android.support.annotation.FloatRange;
import android.support.annotation.IntRange;
import android.support.annotation.NonNull;
import android.support.annotation.Nullable;

import com.yalantis.ucrop.model.AspectRatio;

import java.util.ArrayList;
import java.util.Arrays;
import java.util.Locale;

import androidx.annotation.ColorInt;
import androidx.annotation.DrawableRes;
import androidx.annotation.FloatRange;
import androidx.annotation.IntRange;
import androidx.annotation.NonNull;
import androidx.annotation.Nullable;

/**
* Created by Oleksii Shliama (https://github.com/shliama).
* <p/>
Expand Down Expand Up @@ -152,7 +153,7 @@ public void start(@NonNull Context context, @NonNull Fragment fragment) {
*
* @param fragment Fragment to receive result
*/
public void start(@NonNull Context context, @NonNull android.support.v4.app.Fragment fragment) {
public void start(@NonNull Context context, @NonNull androidx.fragment.app.Fragment fragment) {
start(context, fragment, REQUEST_CROP);
}

Expand All @@ -173,7 +174,7 @@ public void start(@NonNull Context context, @NonNull Fragment fragment, int requ
* @param fragment Fragment to receive result
* @param requestCode requestCode for result
*/
public void start(@NonNull Context context, @NonNull android.support.v4.app.Fragment fragment, int requestCode) {
public void start(@NonNull Context context, @NonNull androidx.fragment.app.Fragment fragment, int requestCode) {
fragment.startActivityForResult(getIntent(context), requestCode);
}

Expand Down
19 changes: 10 additions & 9 deletions ucrop/src/main/java/com/yalantis/ucrop/UCropActivity.java
Original file line number Diff line number Diff line change
Expand Up @@ -9,15 +9,6 @@
import android.net.Uri;
import android.os.Build;
import android.os.Bundle;
import android.support.annotation.ColorInt;
import android.support.annotation.DrawableRes;
import android.support.annotation.IdRes;
import android.support.annotation.IntDef;
import android.support.annotation.NonNull;
import android.support.v4.content.ContextCompat;
import android.support.v7.app.ActionBar;
import android.support.v7.app.AppCompatActivity;
import android.support.v7.widget.Toolbar;
import android.text.TextUtils;
import android.util.Log;
import android.view.Menu;
Expand Down Expand Up @@ -50,6 +41,16 @@
import java.util.List;
import java.util.Locale;

import androidx.annotation.ColorInt;
import androidx.annotation.DrawableRes;
import androidx.annotation.IdRes;
import androidx.annotation.IntDef;
import androidx.annotation.NonNull;
import androidx.appcompat.app.ActionBar;
import androidx.appcompat.app.AppCompatActivity;
import androidx.appcompat.widget.Toolbar;
import androidx.core.content.ContextCompat;

/**
* Created by Oleksii Shliama (https://github.com/shliama).
*/
Expand Down
15 changes: 8 additions & 7 deletions ucrop/src/main/java/com/yalantis/ucrop/UCropFragment.java
Original file line number Diff line number Diff line change
Expand Up @@ -6,13 +6,6 @@
import android.graphics.PorterDuff;
import android.net.Uri;
import android.os.Bundle;
import android.support.annotation.ColorInt;
import android.support.annotation.IdRes;
import android.support.annotation.IntDef;
import android.support.annotation.NonNull;
import android.support.annotation.Nullable;
import android.support.v4.app.Fragment;
import android.support.v4.content.ContextCompat;
import android.text.TextUtils;
import android.view.LayoutInflater;
import android.view.View;
Expand Down Expand Up @@ -41,6 +34,14 @@
import java.util.List;
import java.util.Locale;

import androidx.annotation.ColorInt;
import androidx.annotation.IdRes;
import androidx.annotation.IntDef;
import androidx.annotation.NonNull;
import androidx.annotation.Nullable;
import androidx.core.content.ContextCompat;
import androidx.fragment.app.Fragment;

import static android.app.Activity.RESULT_OK;

@SuppressWarnings("ConstantConditions")
Expand Down
Original file line number Diff line number Diff line change
@@ -1,7 +1,8 @@
package com.yalantis.ucrop.callback;

import android.net.Uri;
import android.support.annotation.NonNull;

import androidx.annotation.NonNull;

public interface BitmapCropCallback {

Expand Down
Original file line number Diff line number Diff line change
@@ -1,11 +1,12 @@
package com.yalantis.ucrop.callback;

import android.graphics.Bitmap;
import android.support.annotation.NonNull;
import android.support.annotation.Nullable;

import com.yalantis.ucrop.model.ExifInfo;

import androidx.annotation.NonNull;
import androidx.annotation.Nullable;

public interface BitmapLoadCallback {

void onBitmapLoaded(@NonNull Bitmap bitmap, @NonNull ExifInfo exifInfo, @NonNull String imageInputPath, @Nullable String imageOutputPath);
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,8 @@

import android.os.Parcel;
import android.os.Parcelable;
import android.support.annotation.Nullable;

import androidx.annotation.Nullable;

/**
* Created by Oleksii Shliama [https://github.com/shliama] on 6/24/16.
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -5,9 +5,6 @@
import android.graphics.RectF;
import android.net.Uri;
import android.os.AsyncTask;
import android.support.annotation.NonNull;
import android.support.annotation.Nullable;
import android.support.media.ExifInterface;
import android.util.Log;

import com.yalantis.ucrop.callback.BitmapCropCallback;
Expand All @@ -20,6 +17,10 @@
import java.io.File;
import java.io.IOException;

import androidx.annotation.NonNull;
import androidx.annotation.Nullable;
import androidx.exifinterface.media.ExifInterface;

/**
* Crops part of image that fills the crop bounds.
* <p/>
Expand Down
Loading

0 comments on commit b05cee9

Please sign in to comment.