Feat/oci dependencies #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes a few bugs related to tls config when installing charts: 1. When installing via relative path, tls config for the selected repository was not being set. 2. The `--ca-file` flag was not being passed when constructing the downloader. 3. Setting tls config was not checking for zero value in repo config, causing flag to get overwritten with empty string. There's still a few oddities here. I would expect that the flag passed in on the command line would override the repo config, but that's not currently the case. Also, we always set the cert, key and ca files as a trio, when they should be set individually depending on combination of flags / repo config. Signed-off-by: James McElwain <jmcelwain@gmail.com>
…or directory size on Linux. Signed-off-by: Pavel Macík <pavel.macik@gmail.com>
Signed-off-by: Guangwen Feng <fenggw-fnst@cn.fujitsu.com>
Signed-off-by: Naseem <naseem@transit.app>
Signed-off-by: Dao Cong Tien <tiendc@vn.fujitsu.com>
After this change, make works on nixos. Signed-off-by: Daniel Poelzleithner <git@poelzi.org>
Use the same install order for hooks as for normal resources (non-hooks) for hooks with equal weight. This makes resource handling more consistent and helps, when there are hook consisting of several resources like e.g. a service account and a job using this service account. The sort functions are changed from an in place search to an out of place sort to avoid inout parameters. Closes helm#7416. Signed-off-by: Daniel Strobusch <1847260+dastrobu@users.noreply.github.com>
…disabled/enabled sub charts Signed-off-by: Florian Hopfensperger <f.hopfensperger@gmail.com>
Resolves helm#7513 As the externalIPs are not managed by k8s (according to the doc: https://kubernetes.io/docs/reference/generated/kubernetes-api/v1.17/#servicespec-v1-core) helm should not wait for services which set al least one externalIPs. Signed-off-by: Federico Bevione <f.bevione@cognitio.it>
…e code duplication Signed-off-by: Matthew Fisher <matt.fisher@microsoft.com>
Signed-off-by: Federico Bevione <f.bevione@cognitio.it>
Signed-off-by: Matt Butcher <matt.butcher@microsoft.com>
Signed-off-by: Reinhard Naegele <unguiculus@gmail.com>
Signed-off-by: Federico Bevione <f.bevione@cognitio.it>
But instead use a newly initialized Scheme with only Kubernetes native resources added. This ensures the 3-way-merge patch strategy is not accidentally chosen for custom resources due to them being added to the global Scheme by e.g. versioned clients while using Helm as a package, and not a self-contained binary. Signed-off-by: Hidde Beydals <hello@hidde.co>
Signed-off-by: Hidde Beydals <hello@hidde.co>
Signed-off-by: Reinhard Naegele <unguiculus@gmail.com>
Signed-off-by: Vibhav Bobade <vibhav.bobde@gmail.com>
Fetching these files is part of the release process. When the new file type was added this step was missed. It will cause the sign make target to fail. Signed-off-by: Matt Farina <matt@mattfarina.com>
Signed-off-by: Rui Chen <chenrui333@gmail.com>
Signed-off-by: ylvmw <yngliu@vmware.com>
Signed-off-by: Zhou Hao <zhouhao@cn.fujitsu.com>
Signed-off-by: Zhou Hao <zhouhao@cn.fujitsu.com>
Add corresponding unit test to the function in parser.go
Signed-off-by: Song Shukun <song.shukun@fujitsu.com>
fix golint failure in pkg/action
fix(helm): Don't wait for service to be ready when external IP are set
fix(kube): use non global Scheme to convert
Signed-off-by: Song Shukun <song.shukun@fujitsu.com>
pkg/helmpath: fix unit test for Windows
Removes the BOM prefix if present, in read files before processing the data. Affects the following pkg: - pkg/chart/loader: directory and archive loader - internal/ignore: when loading .helmignore file Signed-off-by: Thomas FREYSS <thomas.freyss@gmail.com>
Running `helm env` should respect cli flag overrides. Signed-off-by: Adam Reese <adam@reese.io>
Bind Helm flags to Kubernetes configuration loader to get a merged config with kubeconfig. Fixes: helm#7539 Signed-off-by: Adam Reese <adam@reese.io>
Signed-off-by: Josh Dolitsky <393494+jdolitsky@users.noreply.github.com>
In the created chart from `helm create` is notes a tag overrides version. It actually overrides appVersion. Updating the docs to reflect reality. Signed-off-by: Matt Farina <matt@mattfarina.com>
Signed-off-by: Thomas FREYSS <thomas.freyss@gmail.com>
fix(pkg/cli): ensure correct configuration from kubeconfig file
* fix: write index.yaml file atomically This refactors the already-existing `AtomicWriteFile` utility to a central location and uses it to write index files atomically. This is done to avoid having half-written index files break client requests. Drive-bys: - Add test for AtomicWriteFile. - Add test IndexFile.WriteFile. Signed-off-by: rabadin <rvbadin@gmail.com> * Review fix: use RenameWithFallback instead of os.Rename Signed-off-by: rabadin <rvbadin@gmail.com> Co-authored-by: rabadin <rvbadin@gmail.com>
fix(pkg/kube): continue deleting objects when one fails
Signed-off-by: Hu Shuai <hus.fnst@cn.fujitsu.com>
Add unit test for pkg/chart/chart.go
Signed-off-by: Bridget Kromhout <bridget@kromhout.org>
Signed-off-by: Bridget Kromhout <bridget@kromhout.org>
Updating CONTRIBUTING to match current practice
Adding PR template from dev-v2 branch
…elm#7949) * Prints empty repolist in json/yaml if there are no repos and output format is given as json/yaml rather that printing the error msg "no repositories to show" Signed-off-by: Anshul Verma <anshulvermapatel@gmail.com> * Prints empty repolist in json/yaml if there are no repos and output format is given as json/yaml rather that printing the error msg "no repositories to show" Signed-off-by: Anshul Verma <anshulvermapatel@gmail.com>
Remove utf-8 BOM when loading chart files and helmignore
Signed-off-by: Matt Butcher <matt.butcher@microsoft.com>
Signed-off-by: Leo Sjöberg <leo.sjoberg@gmail.com>
Signed-off-by: Leo Sjöberg <leo.sjoberg@gmail.com>
Signed-off-by: Leo Sjöberg <leo.sjoberg@gmail.com>
Signed-off-by: Leo Sjöberg <leo.sjoberg@gmail.com>
Signed-off-by: Leo Sjöberg <leo.sjoberg@gmail.com>
Signed-off-by: Leo Sjöberg <leo.sjoberg@gmail.com>
Signed-off-by: Leo Sjöberg <leo.sjoberg@gmail.com>
Signed-off-by: Leo Sjöberg <leo.sjoberg@gmail.com>
Signed-off-by: Leo Sjöberg <leo.sjoberg@gmail.com>
Signed-off-by: Leo Sjöberg <leo.sjoberg@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.