Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#3 Expose application metrics via jmx #5

Merged
merged 3 commits into from
Aug 22, 2020
Merged

#3 Expose application metrics via jmx #5

merged 3 commits into from
Aug 22, 2020

Conversation

kshashov
Copy link
Owner

For #3 issue

@kshashov kshashov added the enhancement New feature or request label Aug 16, 2020
@kshashov kshashov self-assigned this Aug 16, 2020
@codecov-commenter
Copy link

codecov-commenter commented Aug 16, 2020

Codecov Report

Merging #5 into master will decrease coverage by 1.95%.
The diff coverage is 23.33%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master       #5      +/-   ##
============================================
- Coverage     50.97%   49.02%   -1.96%     
  Complexity      153      153              
============================================
  Files            27       29       +2     
  Lines           720      767      +47     
  Branches        112      114       +2     
============================================
+ Hits            367      376       +9     
- Misses          338      375      +37     
- Partials         15       16       +1     
Impacted Files Coverage Δ Complexity Δ
...b/kshashov/telegram/TelegramAutoConfiguration.java 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
.../telegram/TelegramControllerBeanPostProcessor.java 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
...shashov/telegram/config/TelegramBotProperties.java 0.00% <ø> (ø) 0.00 <0.00> (ø)
...ashov/telegram/handler/TelegramUpdatesHandler.java 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
...shashov/telegram/metrics/MetricsConfiguration.java 0.00% <0.00%> (ø) 0.00 <0.00> (?)
...thub/kshashov/telegram/metrics/MetricsService.java 0.00% <0.00%> (ø) 0.00 <0.00> (?)
.../telegram/handler/processor/RequestDispatcher.java 95.23% <92.85%> (-1.64%) 6.00 <1.00> (ø)
...ashov/telegram/handler/HandlerMethodContainer.java 94.87% <100.00%> (ø) 14.00 <0.00> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3ed890f...fe76043. Read the comment docs.

@kshashov kshashov linked an issue Aug 22, 2020 that may be closed by this pull request
@kshashov kshashov changed the title #3 Expose application metrics via jmx.metrics #3 Expose application metrics via jmx Aug 22, 2020
@kshashov kshashov merged commit 13927e3 into master Aug 22, 2020
@kshashov kshashov deleted the feature/gh-3 branch August 22, 2020 09:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Expose application metrics via jmx
2 participants