check composable in member expression

ktsn · Jun 13, 2023 · 1a62c8d · 1a62c8d
1 parent 3194be0
commit 1a62c8d
Show file tree

Hide file tree

Showing 2 changed files with 34 additions and 4 deletions.
diff --git a/src/rules/composable-placement.ts b/src/rules/composable-placement.ts
@@ -1,4 +1,5 @@
 import { Rule } from 'eslint'
+import * as ESTree from 'estree'
 import { AST } from 'vue-eslint-parser'
 
 const composableNameRE = /^use[A-Z0-9]/
@@ -24,10 +25,23 @@ function getScriptSetupElement(context: Rule.RuleContext): AST.VElement | null {
   return scripts.find((e) => hasAttribute(e, 'setup')) ?? null
 }
 
+function getCalleeName(node: ESTree.Node): string | null {
+  if (node.type === 'Identifier') {
+    return node.name
+  }
+
+  if (node.type === 'MemberExpression') {
+    return getCalleeName(node.property)
+  }
+
+  return null
+}
+
 export default {
   meta: {
     type: 'problem',
   },
+
   create(context) {
     const scriptSetup = getScriptSetupElement(context)
 
@@ -44,10 +58,7 @@ export default {
 
     return {
       CallExpression(node) {
-        if (
-          node.callee.type === 'Identifier' &&
-          node.callee.name.match(composableNameRE)
-        ) {
+        if (getCalleeName(node.callee)?.match(composableNameRE)) {
           const scope = context.sourceCode.getScope(node)
           const block = scope.block as Rule.Node
 

diff --git a/test/composable-placement.spec.ts b/test/composable-placement.spec.ts
@@ -21,6 +21,15 @@ describe('vue-composable/composable-placement', () => {
         }
         `,
       },
+      {
+        code: `
+        import * as foo from './foo'
+
+        export function useBar() {
+          foo.useFoo()
+        }
+        `,
+      },
       {
         code: `
         import { defineComponent } from 'vue'
@@ -76,6 +85,16 @@ describe('vue-composable/composable-placement', () => {
         `,
         errors: [{}],
       },
+      {
+        code: `
+        import * as foo from './foo'
+
+        export function bar() {
+          foo.useFoo()
+        }
+        `,
+        errors: [{}],
+      },
       {
         code: `
         import { useFoo } from './foo'