Fix tmux text being always red
#68
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`tmux` (https://github.com/tmux/tmux/wiki) is a terminal multiplexer, like `screen`. It spawns its terminals with `argv[0]` prefixed with a '-', thus breaking `stderred`'s early return on `bash` encounter. This leads to normal text being always red. When `PROGRAM_NAME` matches the '-%s' format pattern, treat it as a shell and return early. Refer to https://github.com/tmux/tmux/blob/c9d482ab489d5d57d481858091608ee1b32e46ab/window.c#L993 and to tmux/tmux@22d1b94. Fixes ku1ik#52
rico-chet
force-pushed
the
fix-tmux-compat
branch
from
d30f979
to
18689a0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
tmux(https://github.com/tmux/tmux/wiki) is a terminal multiplexer,like
screen. It spawns its terminals withargv[0]prefixed with a'-', thus breaking
stderred's early return onbashencounter. Thisleads to normal text being always red.
When
PROGRAM_NAMEmatches the '-%s' format pattern, treat it as ashell and return early.
Refer to https://github.com/tmux/tmux/blob/c9d482ab489d5d57d481858091608ee1b32e46ab/window.c#L993
and to tmux/tmux@22d1b94.
Fixes #52