Fix ephemeral storage #2
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
apricote
reviewed
Feb 27, 2024
| apiv1.ResourceStorage: *resource.NewQuantity(int64(typeInfo.Disk*1024*1024*1024), resource.DecimalSI), | ||
| apiv1.ResourceEphemeralStorage: *resource.NewQuantity(int64(typeInfo.Disk*1024*1024*1024), resource.DecimalSI), |
There was a problem hiding this comment.
Hey, saw your PR on the upstream autoscaler repo.
The documentation for apiv1.ResourceStorage & apiv1.ResourceStorage is not very clear on this. I think we never should have advertised apiv1.ResourceStorage.
As far as I understood it, apiv1.ResourceStorage is related to the PersistentVolumes that can be attached. ResourceEphemeralStorage is the local disk of the VM, so that one should equal typeInfo.Disk*1024*1024*1024.
There was a problem hiding this comment.
@apricote Yeah I wanted to test it for our users first :P Since we push an image to GHCR before we open a PR.
It fixed it so I will open a pr and remove apiv1.ResourceStorage
Silvest89
force-pushed
the
fix-ephemeral-storage
branch
from
a96379f
to
b756eac
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on the docker-build branch