-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add helper to easily add aws secrets #1133
Conversation
Hi @Jeffwan. Thanks for your PR. I'm waiting for a kubeflow member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
1 similar comment
Hi @Jeffwan. Thanks for your PR. I'm waiting for a kubeflow member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
sdk/python/kfp/aws.py
Outdated
AWS_ACCESS_KEY_ID: YOUR_AWS_ACCESS_KEY_ID | ||
AWS_SECRET_ACCESS_KEY: YOUR_AWS_SECRET_ACCESS_KEY | ||
|
||
We would suggest users to attach minimum policis or roles to get AWS APIs access. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We would suggest users to attach minimum policis or roles to get AWS APIs access. | |
We would suggest users to attach minimum policies or roles to get AWS APIs access. |
This line is a bit unclear. What exactly do we want from users?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Instead of creating a role with lots of permissions, I think it's better to ask users to attach minimum permission based on their needs.
This line is not helpful in the code, I will remove it.
/lgtm |
Fixes #1131 |
@Ark-kun could you help look at my questions in the description? I am trying to make sure all tests pass. |
The current situation is that we run multiple sets of SDK tests: Line 74 in 3e7a89e
To make your test run, you should either rename the test code file or add the test to tests/dsl/main.py .
Let's put the test in tests/dsl for now. We might move it later. |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Ark-kun The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Hi Team,
Add aws secrets in kfp.
sdk/python/tests/run_tests.sh
, my tests are not detected in the results?tests
folder directly? right now it's undertests/dsl
This change is