fix(docs): updated readme wait condition #5371
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NikeNano
changed the title
NikeNano
changed the title
NikeNano
changed the title
|
/assign @Bobgy |
Bobgy
approved these changes
Mar 26, 2021
| @@ -30,7 +30,7 @@ It's based on in-cluster PersistentVolumeClaim storage. | |||
| kubectl apply -k cluster-scoped-resources/ | |||
| kubectl wait crd/applications.app.k8s.io --for condition=established --timeout=60s | |||
| kubectl apply -k env/platform-agnostic/ | |||
| kubectl wait applications/pipeline -n kubeflow --for condition=Ready --timeout=1800s | |||
| kubectl wait pods -l application-crd-id=kubeflow-pipelines -n kubeflow --for condition=Ready --timeout=1800s | |||
There was a problem hiding this comment.
Thank you for flagging this problem!
I think the change is reasonable for backward compatibility.
But we may need a better label selector, because the current one is related to application again.
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Bobgy The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/lgtm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your changes:
For kubeflow version 1.4 the
env/platform-agnosticdont rely on kubernetesapplicationsso suggest that we look at the pods instead for the wait condition.Checklist:
Do you want this pull request (PR) cherry-picked into the current release branch?
Learn more about cherry-picking updates into the release branch.