Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP - updates Azure Terraform example files to allow users to create a cluster within an internal network only #3101

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

mihiragrawal
Copy link
Contributor

What this PR does / why we need it:

This PR updates Azure Terraform example files to allow users to create a cluster within an internal network.
Current Terraform example configs for Azure create public IPs for LB and VMs. However, due to Azure's internal LB hairpin issue, cluster creation failed. Many customers want to create clusters in their internal network.

Which issue(s) this PR fixes:

Fixes #

What type of PR is this?

/kind documentation

Special notes for your reviewer:

Does this PR introduce a user-facing change? Then add your Release Note here:

Updates Azure Terraform example files to allow users to create a cluster within an internal network only

Documentation:


@kubermatic-bot
Copy link
Contributor

@mihiragrawal: Adding the "do-not-merge/docs-needed" label because no documentation block was detected, please follow our documentation process to remove it.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@kubermatic-bot kubermatic-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/documentation Categorizes issue or PR as related to documentation. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. labels Apr 3, 2024
@kubermatic-bot
Copy link
Contributor

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@kubermatic-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign moadqassem for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubermatic-bot kubermatic-bot added do-not-merge/docs-needed Indicates that a PR should not merge because it's missing one of the documentation labels. dco-signoff: no Denotes that at least one commit in the pull request doesn't have a valid DCO signoff message. labels Apr 3, 2024
@kubermatic-bot
Copy link
Contributor

Thanks for your pull request. Before we can look at it, you'll need to add a 'DCO signoff' to your commits.

📝 Please follow instructions in the contributing guide to update your commits with the DCO

Full details of the Developer Certificate of Origin can be found at developercertificate.org.

The list of commits missing DCO signoff:

  • 8d2b63e update terraform example files to have an option for internal network only

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@kubermatic-bot kubermatic-bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Apr 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dco-signoff: no Denotes that at least one commit in the pull request doesn't have a valid DCO signoff message. do-not-merge/docs-needed Indicates that a PR should not merge because it's missing one of the documentation labels. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. kind/documentation Categorizes issue or PR as related to documentation. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants