-
Notifications
You must be signed in to change notification settings - Fork 512
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add labels to PodMetrics interface #996
add labels to PodMetrics interface #996
Conversation
|
Welcome @goenning! |
cc @RCCSilva as you worked on something similar in case you want to help review |
just for reference, this is the response from the API:
|
/lgtm Thanks for the PR! |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: brendandburns, goenning The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Labels were missing on the PodMetrics interface, but were available on the SinglePodMetrics interface. So this PR just adds labels and remove some duplication.
I also made selfLink optional as metrics server doesn't seem to always return it.