Skip to content
This repository has been archived by the owner on Dec 1, 2018. It is now read-only.

Create a plugin-like mechanism for sinks #692

Closed
mwielgus opened this issue Nov 6, 2015 · 5 comments
Closed

Create a plugin-like mechanism for sinks #692

mwielgus opened this issue Nov 6, 2015 · 5 comments

Comments

@mwielgus
Copy link
Contributor

mwielgus commented Nov 6, 2015

At this moment we have a bunch of sinks contributed by the community. I guess none of the core Heapster developers will have time to actively test all of the fancy sinks with the newest release of Kafka, Riemann, Bosun, or some yet another shiny time series database.

I think we have to draw a line between what is fully supported/tested, what is bundled with the default release and what is a best effort add-on/plugin.

cc: @piosz @vishh @jszczepkowski @fgrzadkowski

@piosz
Copy link
Contributor

piosz commented Nov 6, 2015

cc @bgrant0607 @davidopp

@mwielgus
Copy link
Contributor Author

mwielgus commented Nov 6, 2015

related to: #665

@piosz piosz mentioned this issue Nov 6, 2015
@vishh
Copy link
Contributor

vishh commented Nov 6, 2015

Yeah. The best we can do for now is document what we test against.
Setting up integration tests for some of the sinks like kafka and riemann isn't that difficult. We can create a heapster pod with these sinks, re-configure heapster sinks from e2e tests, and then run the necessary sink validation logic.
We can also encourage the community to add e2e tests for those sinks, if they happen to use those sinks in production.

@mwielgus
Copy link
Contributor Author

mwielgus commented Feb 2, 2016

Postponed until after 1.2

@piosz
Copy link
Contributor

piosz commented Nov 25, 2016

closing as obsolete

@piosz piosz closed this as completed Nov 25, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants