Skip to content
This repository has been archived by the owner on Dec 1, 2018. It is now read-only.

Riemann sink #687

Merged
merged 5 commits into from
Nov 6, 2015
Merged

Riemann sink #687

merged 5 commits into from
Nov 6, 2015

Conversation

vishh
Copy link
Contributor

@vishh vishh commented Nov 5, 2015

Credits to @jfoy!

I fixed godeps while adding the required dependencies for riemann!

@jfoy can you test this PR once?

ping @mwielgus @piosz for review.

@googlebot
Copy link

We found a Contributor License Agreement for you (the sender of this pull request) and all commit authors, but as best as we can tell these commits were authored by someone else. If that's the case, please add them to this pull request and have them confirm that they're okay with these commits being contributed to Google. If we're mistaken and you did author these commits, just reply here to confirm.

1 similar comment
@googlebot
Copy link

We found a Contributor License Agreement for you (the sender of this pull request) and all commit authors, but as best as we can tell these commits were authored by someone else. If that's the case, please add them to this pull request and have them confirm that they're okay with these commits being contributed to Google. If we're mistaken and you did author these commits, just reply here to confirm.

jfoy and others added 3 commits November 4, 2015 16:35
Support a Riemann sink (derived from the influxdb sink).

Map Heapster events into Riemann:
* Map Heapster event structures to Riemann events.
* Coerce Int64 metrics to Int for transport to Riemann.
* Support user-provided Riemann tags and event state, with defaults.

Includes basic documentation and sample Riemann config.
Signed-off-by: Vishnu kannan <vishnuk@google.com>
Some repos no longer exist.
Update kube dependency to current v1.1 branch.
Updated coreos fleet support to match godeps.

Signed-off-by: Vishnu kannan <vishnuk@google.com>
Signed-off-by: Vishnu kannan <vishnuk@google.com>
@vishh
Copy link
Contributor Author

vishh commented Nov 5, 2015

@jfoy: I'd appreciate a PR in the future to fix the docs section I have added for Riemann sink.

@piosz piosz mentioned this pull request Nov 5, 2015
@jfoy
Copy link
Contributor

jfoy commented Nov 5, 2015

Will do! Thanks for updating this.

@vishh
Copy link
Contributor Author

vishh commented Nov 5, 2015

I tested this sink myself. This should be good to go.

@piosz
Copy link
Contributor

piosz commented Nov 6, 2015

LGTM, just 2 nits. I've taken a look only into the last commit.

Also please bear in mind #692

Signed-off-by: Vishnu kannan <vishnuk@google.com>
@vishh
Copy link
Contributor Author

vishh commented Nov 6, 2015

@piosz: Thanks for the review. Added comments.

vishh added a commit that referenced this pull request Nov 6, 2015
@vishh vishh merged commit e9816e2 into kubernetes-retired:master Nov 6, 2015
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants