This repository has been archived by the owner on Dec 1, 2018. It is now read-only.
correct the comments of interface Cache #678
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can one of the admins verify this patch? |
|
ok to test |
|
LGTM. Thanks for the PR @bluebreezecf 👍 |
vishh
added a commit
that referenced
this pull request
Oct 27, 2015
correct the comments of interface Cache
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I try to dig into the sources of heapster, and find some comments of interface Cache (in heapster/sinks/cache/cache.go line 91 and 97) may just copy from line 85, and if just
see the comments and method definition, user may get confused.
After reading the implementation in heapster/sinks/cache/impl.go, i modify the method comments
of Cache, aiming at making the methods comments more readable and meaningful.