Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump aws-sdk-go version to v1.44.145 #89

Merged
merged 3 commits into from
Dec 6, 2022
Merged

Bump aws-sdk-go version to v1.44.145 #89

merged 3 commits into from
Dec 6, 2022

Conversation

xdu31
Copy link
Contributor

@xdu31 xdu31 commented Nov 29, 2022

Bump aws-sdk-go version to v1.44.145

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Nov 29, 2022
@k8s-ci-robot
Copy link
Contributor

Welcome @xdu31!

It looks like this is your first PR to kubernetes-sigs/aws-encryption-provider 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/aws-encryption-provider has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot
Copy link
Contributor

Hi @xdu31. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Nov 29, 2022
@k8s-ci-robot k8s-ci-robot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Nov 29, 2022
@wongma7
Copy link

wongma7 commented Nov 30, 2022

/ok-to-test
/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Nov 30, 2022
@k8s-ci-robot k8s-ci-robot added lgtm "Looks good to me", indicates that a PR is ready to be merged. and removed lgtm "Looks good to me", indicates that a PR is ready to be merged. labels Nov 30, 2022
@xdu31
Copy link
Contributor Author

xdu31 commented Dec 1, 2022

/ok-to-test

wongma7
wongma7 reviewed Dec 1, 2022
View reviewed changes
pkg/plugin/plugin.go
@@ -21,6 +21,8 @@ import (
"time"

"github.com/aws/aws-sdk-go/aws"
//nolint
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why is this needed, do you have the golangci-lint error handy? I don't see the lint error https://prow.k8s.io/view/gs/kubernetes-jenkins/pr-logs/pull/kubernetes-sigs_aws-encryption-provider/89/pull-aws-encryption-provider-verify/1598078085045948416

Copy link
Contributor Author

@xdu31 xdu31 Dec 1, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why is this needed, do you have the golangci-lint error handy? I don't see the lint error https://prow.k8s.io/view/gs/kubernetes-jenkins/pr-logs/pull/kubernetes-sigs_aws-encryption-provider/89/pull-aws-encryption-provider-verify/1598078085045948416

The golangci-lint is complaining about awserr not used, which is actually used, there's similar thread about wrong judgement from golangci-lint, golangci/golangci-lint#2214, someone claimed to fix some failure with golang version bump from 1.15 to 1.16, however, aws-encryption-provider has a hard limit on golang 1.15 as https://prow.k8s.io/view/gs/kubernetes-jenkins/pr-logs/pull/kubernetes-sigs_aws-encryption-provider/89/pull-aws-encryption-provider-verify/1598229690533810176.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see. also I didn't know about the protobuf thing, that sounds worrisome, thanks

@wongma7
Copy link

wongma7 commented Dec 1, 2022

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 1, 2022
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 5, 2022
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Dec 5, 2022
micahhausler
micahhausler reviewed Dec 5, 2022
View reviewed changes
go.mod Outdated
@@ -31,3 +31,5 @@ replace github.com/golangci/lint-1 v0.0.0-20180610141402-ee948d087217 => github.
replace github.com/timakin/bodyclose => github.com/golangci/bodyclose v0.0.0-20190714144026-65da19158fa2

replace mvdan.cc/unparam v0.0.0-20190124213536-fbb59629db34 => mvdan.cc/unparam v0.0.0-20190209190245-fbb59629db34

replace golang.org/x/sys => golang.org/x/sys v0.0.0-20220811171246-fbc7d0a398ab
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why this change?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why this change?

@micahhausler This to fix undefined: unsafe.Slice errors introduced by the aws-sdk-go version bump up. The unsafe.Slice was added as part of Go 1.17, we are using Go 1.15 in aws-encryption-provider. I took the accept answer in https://stackoverflow.com/questions/74049351/gcloud-functions-deploy-go-runtime-error-undefined-unsafe-slice-error-id-2f5

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Go 1.15 is unmaintained... why don't we bump the Go version to something newer. I think you can just bump it in this PR

@xdu31 xdu31 requested review from micahhausler and removed request for justinsb December 5, 2022 20:57
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Dec 5, 2022
@micahhausler
Copy link
Member

/ok-to-test
/retest

@micahhausler
Copy link
Member

/retest

@k8s-ci-robot k8s-ci-robot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Dec 5, 2022
@xdu31 xdu31 requested review from wongma7 and micahhausler and removed request for micahhausler and wongma7 December 5, 2022 23:14
@micahhausler
Copy link
Member

/lgmt
/approve

@micahhausler
Copy link
Member

/lgtm

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: micahhausler, wongma7, xdu31

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 6, 2022
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 6, 2022
@k8s-ci-robot k8s-ci-robot merged commit d63ba39 into kubernetes-sigs:master Dec 6, 2022
This was referenced Dec 6, 2022
Merged
Closed
@xdu31 xdu31 mentioned this pull request Mar 16, 2023
Closed
9 tasks
@micahhausler micahhausler mentioned this pull request Jan 22, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@micahhausler micahhausler micahhausler left review comments

@wongma7 wongma7 Awaiting requested review from wongma7

Assignees

@micahhausler micahhausler

@wongma7 wongma7

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@xdu31 @k8s-ci-robot @wongma7 @micahhausler