-
Notifications
You must be signed in to change notification settings - Fork 423
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
prepare v0.5.11 release #510
prepare v0.5.11 release #510
Conversation
Allow init to respect the state directory and kubeconfig paths by toggling a feature gate Co-authored-by: - Daniel Seymour <danny.seymour@gremlin.com> - Nicholas Turner <nic@amazon.com>
- Print commit id in addition to version - Only log for specific commands starting with init and server
to run it: make start-dev-dynamicfile
Update Makefile to support run e2e from either kind or kops. make e2e RUNNER=kind #to run e2e on kind make e2e RUNNER=kops #to run e2e on kops
Hi @nnmin-aws. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Why is 1acb533 included? |
@@ -56,6 +56,7 @@ write_kind_config | |||
create_kind_cluster | |||
certificate_authority_data="$(extract_certificate_authority_data)" | |||
write_kubectl_kubeconfig | |||
echo "start end to end testing for mountfile mode" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My only nit is this is called "start dev env" but its used to run e2e tests. Do you use this for both? I'd like to separate them and have e2e tests run from the e2e script and dev envs set up from the dev script, and just have options to choose between dynamic file or other backends. We can do that in a future improvement if you'd like.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks @nckturner! this is a good point. I will create a separate PR after this cherry-pick to move the e2e out.
thanks @nckturner for the comments. |
/ok-to-test |
For PR description, please make any changes if I've made a mistake: 73a09f0, c6a2c08, af5db65, 8684614, bdfc6d2: These commits are included to enable e2e testing on this branch. 5d89d57: Minor bugfix related to dev env file permissions. 45777aa: This feature is being cherry picked to release-0.5 to support a feature launch in EKS--some platform versions use the release-0.5 branch and we need feature support in those versions. da8510b, bcdcb3a: Print version on startup to make debugging easier. 14e71c2: E2E test for 45777aa. ce87d8a: Update go version used to build. 1acb533: Remove dependency of 45777aa on the SSO PR. 052daeb: Add makefile target for new e2e test. |
/lgtm |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: nckturner, nnmin-aws The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This PR cherry picks PR merged on master branch to branch release-0.5.
It picked up the following pr in summary: