Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump dependencies and go version (in go.mod) #547

Merged

Conversation

dims
Copy link
Member

@dims dims commented Jan 19, 2023

We have new version of k8s, let's switch to the v1.26.x and the dependencies that version uses as well. If it is not in k8s go.mod then pick new versions directly from the dependencies.

  • update to v2 for ginkgo
  • adapt to the changes in k8s.io test framework

Signed-off-by: Davanum Srinivas davanum@gmail.com

What this PR does / why we need it:

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jan 19, 2023
@dims
Copy link
Member Author

dims commented Jan 19, 2023

/assign @nckturner @nnmin-aws

1 similar comment
@dims
Copy link
Member Author

dims commented Jan 19, 2023

/assign @nckturner @nnmin-aws

@dims dims force-pushed the bump-dependencies-and-go-version branch 3 times, most recently from 5580c90 to 27cba1c Compare January 19, 2023 12:33
@dims dims mentioned this pull request Jan 19, 2023
@dims dims force-pushed the bump-dependencies-and-go-version branch from 27cba1c to 5b1accd Compare January 19, 2023 12:49
@k8s-ci-robot k8s-ci-robot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jan 19, 2023
@nnmin-aws
Copy link
Contributor

apology for your inconvenience @dims. I will check on the failure and get back

@dims dims force-pushed the bump-dependencies-and-go-version branch 12 times, most recently from 8032bbe to ba5c901 Compare January 20, 2023 16:47
@dims dims force-pushed the bump-dependencies-and-go-version branch 3 times, most recently from 050b8a0 to 2f7e0b9 Compare January 21, 2023 14:24
We have new version of k8s, let's switch to the v1.26.x and the dependencies
that version uses as well. If it is not in k8s go.mod then pick new versions
directly from the dependencies.

Signed-off-by: Davanum Srinivas <davanum@gmail.com>
Signed-off-by: Davanum Srinivas <davanum@gmail.com>
@dims dims force-pushed the bump-dependencies-and-go-version branch 6 times, most recently from 0606066 to 7bba870 Compare January 21, 2023 20:41
…ain barfs on

Signed-off-by: Davanum Srinivas <davanum@gmail.com>
@dims dims force-pushed the bump-dependencies-and-go-version branch from 7bba870 to 35ca464 Compare January 21, 2023 21:34
@nckturner
Copy link
Contributor

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dims, nckturner

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 25, 2023
Signed-off-by: Davanum Srinivas <davanum@gmail.com>
@nckturner
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added lgtm "Looks good to me", indicates that a PR is ready to be merged. and removed lgtm "Looks good to me", indicates that a PR is ready to be merged. labels Jan 25, 2023
@nckturner
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 25, 2023
@k8s-ci-robot k8s-ci-robot merged commit d418386 into kubernetes-sigs:master Jan 25, 2023
k8s-ci-robot added a commit that referenced this pull request Mar 28, 2023
cherry pick PR #547 to release-0.5
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants