Skip to content

Commit

Permalink
Apply grammar suggestions from code review
Browse files Browse the repository at this point in the history
Co-authored-by: John Gardiner Myers <jgmyers@proofpoint.com>
  • Loading branch information
yubingjiaocn and johngmyers authored Jul 30, 2023
1 parent c3eaa90 commit 85ea2b1
Showing 1 changed file with 3 additions and 3 deletions.
6 changes: 3 additions & 3 deletions docs/guide/ingress/annotations.md
Original file line number Diff line number Diff line change
Expand Up @@ -81,11 +81,11 @@ By default, Ingresses don't belong to any IngressGroup, and we treat it as a "im
We'll add more fine-grained access-control in future versions.

!!!note "Rename behavior"
The ALB for an IngressGroup is found by searching for an AWS tag `ingress.k8s.aws/stack` tag with the name of the IngressGroup as its value. For implicit IngressGroup, the value is `namespace/ingressname`.
The ALB for an IngressGroup is found by searching for an AWS tag `ingress.k8s.aws/stack` tag with the name of the IngressGroup as its value. For an implicit IngressGroup, the value is `namespace/ingressname`.

When the groupName of IngressGroup for Ingress is changed, the Ingress will be moved to new IngressGroup and supported by ALB for the new IngressGroup. If ALB for the new IngressGroup doesn't exist, a new ALB will be created.
When the groupName of an IngressGroup for an Ingress is changed, the Ingress will be moved to a new IngressGroup and be supported by the ALB for the new IngressGroup. If the ALB for the new IngressGroup doesn't exist, a new ALB will be created.

If an IngressGroup no longer contain any Ingresses, ALB for the IngressGroup will be deleted, and deletion protection of ALB will be ignored.
If an IngressGroup no longer contains any Ingresses, the ALB for that IngressGroup will be deleted and any deletion protection of that ALB will be ignored.

!!!example
```
Expand Down

0 comments on commit 85ea2b1

Please sign in to comment.