-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cannot separately define health checks for HTTP and gRPC when combined on one Ingress #3397
Comments
@erhudy, sorry for the late reply. I think your request is kind of similar to this issue: #3346 |
👍 on this. I have a similar use case for HTTP and HTTPS. I would very much like this feature. |
The Kubernetes project currently lacks enough contributors to adequately respond to all issues. This bot triages un-triaged issues according to the following rules:
You can:
Please send feedback to sig-contributor-experience at kubernetes/community. /lifecycle stale |
The Kubernetes project currently lacks enough active contributors to adequately respond to all issues. This bot triages un-triaged issues according to the following rules:
You can:
Please send feedback to sig-contributor-experience at kubernetes/community. /lifecycle rotten |
The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs. This bot triages issues according to the following rules:
You can:
Please send feedback to sig-contributor-experience at kubernetes/community. /close not-planned |
@k8s-triage-robot: Closing this issue, marking it as "Not Planned". In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Describe the bug
When using
conditions
cleverness to combine both regular HTTP and gRPC services on a single Ingress (i.e., write a condition that steers traffic to a service offering gRPC ifContent-Type: application/grpc
), it is not possible to define separate health checks for the two target groups that are generated by the controller. If both services are able to use the default health checks, great, but this is probably not the case.Steps to reproduce
Write an Ingress with conditions annotations that route traffic to a gRPC service if the Content-Type is
application/grpc
.Expected outcome
I know the controller doesn't support defining separate health checks for HTTP vs gRPC target groups on the same ingress, so this outcome is actually expected.
What I would like to be possible is to be able to define separate health check parameters for gRPC services, with all the existing health check annotations duplicated to gRPC-specific ones:
For full backwards compatibility, the existing behavior would be maintained. If any of these annotations is present, it would configure health check behavior for a gRPC service only.
Environment
Additional Context:
Maybe you think this is an insane use case. Maybe it is! But if the LB controller allows this kind of orthogonality through defining all sorts of crazy conditions, it should probably also allow it for health checks.
The text was updated successfully, but these errors were encountered: