Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix consistency of version references in documentation, etc. #2880

Merged
merged 4 commits into from
Nov 16, 2022
Merged

Fix consistency of version references in documentation, etc. #2880

merged 4 commits into from
Nov 16, 2022

Conversation

johngmyers
Copy link
Contributor

Issue

When the 2.4.5 release was cut, not all references to the 2.4.4 version were updated.

Description

Creates a hack/set-version script for updating the version number of a release. Adds a check to GitHub actions to ensure all versions in the repo are set consistently.

Checklist

  • Added tests that cover your change (if possible)
  • Added/modified documentation as required (such as the README.md, or the docs directory)
  • Manually tested
  • Made sure the title of the PR is a good description that can go into the release notes

BONUS POINTS checklist: complete for good vibes and maybe prizes?! 🤯

  • Backfilled missing tests for code in same general area 🎉
  • Refactored something and made the world a better place 🌟

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Nov 13, 2022
@codecov-commenter
Copy link

Codecov Report

Base: 54.05% // Head: 54.05% // No change to project coverage 👍

Coverage data is based on head (6412f74) compared to base (e45d40f).
Patch has no changes to coverable lines.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #2880   +/-   ##
=======================================
  Coverage   54.05%   54.05%           
=======================================
  Files         144      144           
  Lines        8278     8278           
=======================================
  Hits         4475     4475           
  Misses       3479     3479           
  Partials      324      324

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@johngmyers johngmyers mentioned this pull request Nov 13, 2022
Merged
6 tasks
@kishorj kishorj added the tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges. label Nov 14, 2022
kishorj
kishorj reviewed Nov 14, 2022
View reviewed changes
Copy link
Collaborator

@kishorj kishorj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a bunch. I have some minor comments regarding themanifest name

docs/deploy/installation.md Outdated
@@ -190,7 +190,7 @@ We recommend using the Helm chart. This supports Fargate and facilitates updatin
### Apply YAML
1. Download spec for load balancer controller.
```
wget https://github.com/kubernetes-sigs/aws-load-balancer-controller/releases/download/v2.4.4/v2_4_4_full.yaml
wget https://github.com/kubernetes-sigs/aws-load-balancer-controller/releases/download/v2.4.5/v2_4_4_full.yaml
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

v2_4_5_full.yaml

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed

docs/deploy/installation.md Outdated Show resolved Hide resolved
@kishorj
Copy link
Collaborator

kishorj commented Nov 14, 2022

/retest

@kishorj
Copy link
Collaborator

kishorj commented Nov 15, 2022

I need to investigate the e2e failures, please don't flag for retest.

@kishorj
Copy link
Collaborator

kishorj commented Nov 15, 2022

/retest

@kishorj
Copy link
Collaborator

kishorj commented Nov 15, 2022

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 15, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: johngmyers, kishorj

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 15, 2022
@k8s-ci-robot k8s-ci-robot merged commit 8d2ee85 into kubernetes-sigs:main Nov 16, 2022
@johngmyers johngmyers deleted the verify-release branch November 16, 2022 00:06
@kishorj kishorj mentioned this pull request Jan 12, 2023
Merged
@johngmyers johngmyers mentioned this pull request Jan 24, 2023
Merged
@johngmyers johngmyers mentioned this pull request Aug 23, 2023
Merged
12 tasks
Timothy-Dougherty pushed a commit to adammw/aws-load-balancer-controller that referenced this pull request Nov 9, 2023
@johngmyers @Timothy-Dougherty
Fix consistency of version references in documentation, etc. (kuberne…
3ef7d49 
…tes-sigs#2880)

* Create hack/set-version

* Update tags for previous release

* Verify version is set consistently throughout repo

* Fix manifest names in installation.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kishorj kishorj kishorj left review comments

@M00nF1sh M00nF1sh Awaiting requested review from M00nF1sh

Assignees

@kishorj kishorj

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@johngmyers @codecov-commenter @kishorj @k8s-ci-robot