Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: fix gRPCServer example #2954

Merged
merged 7 commits into from
Jan 2, 2023
Merged

docs: fix gRPCServer example #2954

merged 7 commits into from
Jan 2, 2023

Conversation

prasadkatti
Copy link
Contributor

@prasadkatti prasadkatti commented Jan 2, 2023 •
edited
Loading

Description

fixed the gRPCServer example.

Checklist

  • Added tests that cover your change (if possible)
  • Added/modified documentation as required (such as the README.md, or the docs directory)
  • Manually tested
  • Made sure the title of the PR is a good description that can go into the release notes

BONUS POINTS checklist: complete for good vibes and maybe prizes?! 🤯

  • Backfilled missing tests for code in same general area 🎉
  • Refactored something and made the world a better place 🌟

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jan 2, 2023
@k8s-ci-robot
Copy link
Contributor

Hi @prasadkatti. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jan 2, 2023
prasadkatti
prasadkatti commented Jan 2, 2023
View reviewed changes
docs/examples/grpc_server.md

```bash
kubectl logs -n kube-system $(kubectl get po -n kube-system | egrep -o 'aws-load-balancer-controller[a-zA-Z0-9-]+') | grep 'grpcserver\/grpcserver'
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The old command does not work because the k get po command returns 2 pods. So the k logs command fails with -

error: container <pod-1> is not valid for pod <pod-2>

I am guessing it worked before because there was only 1 replica running.

prasadkatti
prasadkatti commented Jan 2, 2023
View reviewed changes
docs/examples/grpc_server.md
NNAME CLASS HOSTS ADDRESS PORTS AGE
grpcserver <none> YOUR_DOMAIN_NAME ALB-NAME.us-east-1.elb.amazonaws.com 80 90m
NNAME CLASS HOSTS ADDRESS PORTS AGE
grpcserver alb YOUR_DOMAIN_NAME ALB-DNS-NAME 80 90m
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed the CLASS value to alb

@kishorj kishorj added the tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges. label Jan 2, 2023
kishorj
kishorj reviewed Jan 2, 2023
View reviewed changes
Copy link
Collaborator

@kishorj kishorj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks.

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kishorj, prasadkatti

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 2, 2023
@kishorj
Copy link
Collaborator

kishorj commented Jan 2, 2023

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 2, 2023
@k8s-ci-robot k8s-ci-robot merged commit 5634fa2 into kubernetes-sigs:main Jan 2, 2023
@prasadkatti prasadkatti deleted the grpc-docs branch January 2, 2023 20:45
@kishorj kishorj mentioned this pull request Jan 12, 2023
Merged
Timothy-Dougherty pushed a commit to adammw/aws-load-balancer-controller that referenced this pull request Nov 9, 2023
@prasadkatti @johngmyers @Timothy-Dougherty
docs: fix gRPCServer example (kubernetes-sigs#2954)
6b910a2 
* docs: make external-dns optional in echoserver walkthrough

* Update link to external-dns

Co-authored-by: John Gardiner Myers <jgmyers@proofpoint.com>

* use the `alb.ingress.kubernetes.io/ssl-redirect` annotation

* misc docs fixes

* update commands to verify logs for awslbc and external-dns

Co-authored-by: John Gardiner Myers <jgmyers@proofpoint.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kishorj kishorj kishorj approved these changes

@M00nF1sh M00nF1sh Awaiting requested review from M00nF1sh

Assignees

@kishorj kishorj

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@prasadkatti @k8s-ci-robot @kishorj