-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add SSLPolicy field to IngressClassParams #3025
Conversation
Codecov ReportBase: 54.31% // Head: 54.37% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #3025 +/- ##
==========================================
+ Coverage 54.31% 54.37% +0.05%
==========================================
Files 145 145
Lines 8412 8414 +2
==========================================
+ Hits 4569 4575 +6
+ Misses 3513 3509 -4
Partials 330 330
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
4a64c46
to
72dbbb6
Compare
72dbbb6
to
6d1dfb6
Compare
6d1dfb6
to
2c207f9
Compare
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: johngmyers, kishorj The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
* Add SSLPolicy field to IngressClassParams * Fix typo Co-authored-by: Tim Bannister <tim@scalefactory.com> --------- Co-authored-by: Tim Bannister <tim@scalefactory.com>
Merge in DEL/aws-load-balancer-controller-fork from update-from-upstream to main * commit '9bbcc80fd4e701018636af4147b27d69e4f128d3': update ko to v0.13.0 (kubernetes-sigs#3115) update module dependencies (kubernetes-sigs#3114) added validation for dummy ports introduced in the aws-load-balancer-ssl-ports annotation (kubernetes-sigs#3067) docs: add a new page about security groups management (kubernetes-sigs#2988) Add InboundCIDRs field to IngressClassParams (kubernetes-sigs#3089) Add SSLPolicy field to IngressClassParams (kubernetes-sigs#3025) enable EndpointsFailOpen by default (kubernetes-sigs#3078)
* Add SSLPolicy field to IngressClassParams * Fix typo Co-authored-by: Tim Bannister <tim@scalefactory.com> --------- Co-authored-by: Tim Bannister <tim@scalefactory.com>
Issue
#2920
Description
Adds a
sslPolicy
field toIngressClassParams
, permitting anIngressClass
to override the SSL policy for allIngresses
in the class.Checklist
README.md
, or thedocs
directory)BONUS POINTS checklist: complete for good vibes and maybe prizes?! 🤯