cache ELB resource tags to reduce API calls #3550
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Description
Backgroud:
By default, during reconcile for a Ingress/Service, the controller will need to find the ALB/NLB created for Ingress/Service. It achieves it by looking for ALB/NLB tagged with certain tags. However, the ELBv2 API don't support filter ALB/NLB with certain tags, thus we have to list all ALB/NLB in VPC and then list the tags on each of them. This is inefficient when there is large number of ALB/NLBs in vpc.
Note, there is a optional feature that uses RGT API, which supports directly filter ALB/NLB with certain tags, however that API requires internet access and not suitable for private clusters.
Changes done:
This PR will
Checklist
README.md
, or thedocs
directory)BONUS POINTS checklist: complete for good vibes and maybe prizes?! 🤯