Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update the traffic test for ingress #3725

Merged
merged 2 commits into from
May 30, 2024
Merged

update the traffic test for ingress #3725

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
25bdc3b
update the traffic test for ingress
oliviassss May 29, 2024
f0727f3
make crds
oliviassss May 29, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions config/webhook/manifests.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
---
apiVersion: admissionregistration.k8s.io/v1
kind: MutatingWebhookConfiguration
metadata:
Expand Down
13 changes: 9 additions & 4 deletions test/e2e/ingress/vanilla_ingress_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -766,10 +766,15 @@ var _ = Describe("vanilla ingress tests", func() {

// test traffic
ExpectLBDNSBeAvailable(ctx, tf, lbARN, lbDNS)
httpExp := httpexpect.New(tf.LoggerReporter, fmt.Sprintf("http://%v", lbDNS))
httpExp.GET("/path").Expect().
Status(http.StatusOK).
Body().Equal("Hello World!")

//TODO: update the traffic test for dualstack-without-public-ipv4 ALB
// as it may need additional setup compared to dualstack ALB
if annotation["alb.ingress.kubernetes.io/ip-address-type"] != "dualstack-without-public-ipv4" {
httpExp := httpexpect.New(tf.LoggerReporter, fmt.Sprintf("http://%v", lbDNS))
httpExp.GET("/path").Expect().
Status(http.StatusOK).
Body().Equal("Hello World!")
}
})
})
})
Expand Down
Loading