Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bump up go to 1.22.5 #3798

Merged
merged 1 commit into from
Aug 8, 2024
Merged

bump up go to 1.22.5 #3798

merged 1 commit into from
Aug 8, 2024

Conversation

oliviassss
Copy link
Collaborator

Issue

fix the failure in go vuln check: https://github.com/kubernetes-sigs/aws-load-balancer-controller/actions/runs/10309357846/job/28538823281?pr=3797

Description

Checklist

  • Added tests that cover your change (if possible)
  • Added/modified documentation as required (such as the README.md, or the docs directory)
  • Manually tested
  • Made sure the title of the PR is a good description that can go into the release notes

BONUS POINTS checklist: complete for good vibes and maybe prizes?! 🤯

  • Backfilled missing tests for code in same general area 🎉
  • Refactored something and made the world a better place 🌟

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Aug 8, 2024
@shraddhabang
Copy link
Collaborator

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 8, 2024
@M00nF1sh
Copy link
Collaborator

M00nF1sh commented Aug 8, 2024

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: M00nF1sh, oliviassss, shraddhabang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [M00nF1sh,oliviassss]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@oliviassss oliviassss merged commit 2556198 into kubernetes-sigs:main Aug 8, 2024
7 of 9 checks passed
M00nF1sh pushed a commit to M00nF1sh/aws-load-balancer-controller that referenced this pull request Aug 9, 2024
@oliviassss @M00nF1sh
bump up go to 1.22.5 (kubernetes-sigs#3798)
3252c21
@M00nF1sh M00nF1sh mentioned this pull request Aug 9, 2024
Merged
6 tasks
M00nF1sh added a commit that referenced this pull request Aug 9, 2024
@M00nF1sh @oliviassss
cherry-pick commits from main into release-2.8 (#3801)
8001b59 
* bump up go to 1.22.5 (#3798)

* keep LB addons' settings unchanged unless explicitly specified (#3800)

add UTs for related components

---------

Co-authored-by: Olivia Song <sonyingy@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kishorj kishorj Awaiting requested review from kishorj

@M00nF1sh M00nF1sh Awaiting requested review from M00nF1sh

Assignees

@shraddhabang shraddhabang

@M00nF1sh M00nF1sh

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@oliviassss @shraddhabang @M00nF1sh @k8s-ci-robot